From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8E415DF1D for ; Wed, 6 Mar 2024 14:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709737152; cv=none; b=bI3SD4KAChOCYpliLzu0ZN1jpd6Uw3ELIF2Fon+QLY3rK6YAxgKiZXKkPBLUxX96R0KJm9j/9u1k1sQCeaYIxR1dOBAKaHsXwYUEtRn+5KuYYfoZ1pdsW/mNZLJgXsXSZen3SL6oUw/V4G1w8JTILDinqVRjcVS3ZGEDwIMjEL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709737152; c=relaxed/simple; bh=5z1WIiQbdKj3wDMOUndzTSJXEn23YXgg5na9zp/yfd4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XYhy7yX5fdyLCr1B5GrkVv+SdvMAOfSZOZ57WgdS6x/4EoYVe5Li/fho+A5KiTSbiHqxHtq9mT10ZJM/ozt1IpcbLiuZsjTt1ku2MhVqVc7bF4IRoVshgZCwbw3T5pMvnz50qQ7c+dnURs+QcxyKZlLg7Bw+1EnJciaQPcc30sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=MDC/01am; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="MDC/01am" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-56454c695e6so1738278a12.0 for ; Wed, 06 Mar 2024 06:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1709737148; x=1710341948; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=NCQzS2U+X6BJrRf6UDzdIXPeRu9oZvG7xtYVzAs6Kxw=; b=MDC/01amgS1nkMLAGkWNQAXI8ZNPilv4MTPzm7q0B9ihH5WZhiy2R4oT+FLRPVyBOJ 3qEO94F9aOSipdCGtstkqdAOoIbXt+Iw1RQJwrya8u3M64P8qPNvRZ3FzoIxuodvHd54 svPXnlpEtzl/N+/vU36BZYoQB1KVleTBkvcsCapRV8udkLd37kRMYe1bHT8iAUJLmHZX efjRCnCbcJnMM7JPNMDZOU3snjc45EjrYUPAHMJdqfaWJbW0B9rd8AoYqUKknfLa+ahX AifLK2G8QX8yFgEylpGqDntWKJmu4JOeo9xg/+YP03dVsWF4pnvR1ClyZlLK1h19xela jY1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709737148; x=1710341948; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NCQzS2U+X6BJrRf6UDzdIXPeRu9oZvG7xtYVzAs6Kxw=; b=p/kBgXZIIqkc74O1fdx5X+e8kQjrdnJIYgOnHRNud3pzGNO1tTzr82KPykiQyNEAkh Fpbzm3ddJCbnB3nDut+RyLjRZ6ReH1LAUIeX4/MdwnHwf+1TpW2X93mrF69NpBdZolYj F8ZcVpDmPBsG1Nks0JxjK79JYwxZLXhOUA6JhvrTx65Tsy0FUomra3JGUpyn5OX7mMB/ BJ/FbCTV3wu8NS27nOjh8MlwOg0Y+DnWReRoz7OCd82R1NkpqaPTkUZLkn+Xhm1ES0Q9 bUR+JnXfhRD0LpppflczjXIxaSNGLPzHbogQDYrG4oIjeT0Mw4d8KkfryLwPHBPBiJPu TcZg== X-Gm-Message-State: AOJu0YzUtUkWfeICGdVr7ahPZltE4kvp8aC3dnQSdR5LJ8edWd5wVcLi Qu8O9rW5nG7wRoCb1hIMs0VsnaFMmjPastfpbpdpPPteQqS73WAFyP2d0oNQ9Lyit4VdGV1iVCS Q X-Google-Smtp-Source: AGHT+IG8svtpofGZ8VLe9a8pAoWZJ+udFgMIWyO5Y7i0Pcz/HHvTrAjGeOHnL9ydzhS1880OfyBFtQ== X-Received: by 2002:aa7:d882:0:b0:567:e6c:c60f with SMTP id u2-20020aa7d882000000b005670e6cc60fmr5852589edq.16.1709737148143; Wed, 06 Mar 2024 06:59:08 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:0:2746:4b81:593e:203b? ([2001:67c:2fbc:0:2746:4b81:593e:203b]) by smtp.gmail.com with ESMTPSA id be27-20020a0564021a3b00b0056650031d94sm7009992edb.90.2024.03.06.06.59.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 06:59:07 -0800 (PST) Message-ID: <3222b8fc-8591-4f26-a29f-c0aea7b2dfda@openvpn.net> Date: Wed, 6 Mar 2024 15:59:32 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 04/22] ovpn: add basic interface creation/destruction/management routines Content-Language: en-US To: Jakub Kicinski Cc: netdev@vger.kernel.org, Sergey Ryazanov , Paolo Abeni , Eric Dumazet References: <20240304150914.11444-1-antonio@openvpn.net> <20240304150914.11444-5-antonio@openvpn.net> <20240305114028.34f8c253@kernel.org> From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EY5uLRwEIAME8xlSi3VYmrBJBcWB1ALDxcOqo+IQFcRR+hLVHGH/f4u9a8yUd BtlgZicNthCMA0keGtSYGSxJha80LakG3zyKc2uvD3rLRGnZCXfmFK+WPHZ67x2Uk0MZY/fO FsaMeLqi6OE9X3VL9o9rwlZuet/fA5BP7G7v0XUwc3C7Qg1yjOvcMYl1Kpf5/qD4ZTDWZoDT cwJ7OTcHVrFwi05BX90WNdoXuKqLKPGw+foy/XhNT/iYyuGuv5a7a1am+28KVa+Ls97yLmrq Zx+Zb444FCf3eTotsawnFUNwm8Vj4mGUcb+wjs7K4sfhae4WTTFKXi481/C4CwsTvKpaMq+D VosAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJjm4tHAhsMBQkCx+oA AAoJEEjwzLaPWdFMv4AP/2aoAQUOnGR8prCPTt6AYdPO2tsOlCJx/2xzalEb4O6s3kKgVgjK WInWSeuUXJxZigmg4mum4RTjZuAimDqEeG87xRX9wFQKALzzmi3KHlTJaVmcPJ1pZOFisPS3 iB2JMhQZ+VXOb8cJ1hFaO3CfH129dn/SLbkHKL9reH5HKu03LQ2Fo7d1bdzjmnfvfFQptXZx DIszv/KHIhu32tjSfCYbGciH9NoQc18m9sCdTLuZoViL3vDSk7reDPuOdLVqD89kdc4YNJz6 tpaYf/KEeG7i1l8EqrZeP2uKs4riuxi7ZtxskPtVfgOlgFKaeoXt/budjNLdG7tWyJJFejC4 NlvX/BTsH72DT4sagU4roDGGF9pDvZbyKC/TpmIFHDvbqe+S+aQ/NmzVRPsi6uW4WGfFdwMj 5QeJr3mzFACBLKfisPg/sl748TRXKuqyC5lM4/zVNNDqgn+DtN5DdiU1y/1Rmh7VQOBQKzY8 6OiQNQ95j13w2k+N+aQh4wRKyo11+9zwsEtZ8Rkp9C06yvPpkFUcU2WuqhmrTxD9xXXszhUI ify06RjcfKmutBiS7jNrNWDK7nOpAP4zMYxYTD9DP03i1MqmJjR9hD+RhBiB63Rsh/UqZ8iN VL3XJZMQ2E9SfVWyWYLTfb0Q8c4zhhtKwyOr6wvpEpkCH6uevqKx4YC5 Organization: OpenVPN Inc. In-Reply-To: <20240305114028.34f8c253@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2024 20:40, Jakub Kicinski wrote: > On Mon, 4 Mar 2024 16:08:55 +0100 Antonio Quartulli wrote: >> + dev = alloc_netdev(sizeof(struct ovpn_struct), name, NET_NAME_USER, ovpn_setup); >> + >> + dev_net_set(dev, net); > > the dev allocation never fails? Or the error is handles somewhere else? It definitely can fail and dev_net_set will crash. My bad. Thanks for reporting this. Regards, -- Antonio Quartulli OpenVPN Inc.