Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Yuyang Huang <yuyanghuang@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Simon Horman" <horms@kernel.org>,
	"David Ahern" <dsahern@kernel.org>,
	roopa@cumulusnetworks.com, jiri@resnulli.us,
	stephen@networkplumber.org, jimictw@google.com, prohr@google.com,
	liuhangbin@gmail.com, nicolas.dichtel@6wind.com, andrew@lunn.ch,
	netdev@vger.kernel.org, "Maciej Żenczykowski" <maze@google.com>,
	"Lorenzo Colitti" <lorenzo@google.com>,
	"Patrick Ruddy" <pruddy@vyatta.att-mail.com>
Subject: Re: [PATCH net-next, v3] netlink: add IGMP/MLD join/leave notifications
Date: Thu, 21 Nov 2024 10:14:54 +0100	[thread overview]
Message-ID: <322e75ab-8ae8-4dd0-9646-ef41d9ff2fba@redhat.com> (raw)
In-Reply-To: <20241121054711.818670-1-yuyanghuang@google.com>

On 11/21/24 06:47, Yuyang Huang wrote:
> @@ -901,6 +904,58 @@ static struct ifmcaddr6 *mca_alloc(struct inet6_dev *idev,
>  	return mc;
>  }
>  
> +static int inet6_fill_ifmcaddr(struct sk_buff *skb, struct net_device *dev,
> +			       const struct in6_addr *addr, int event)
> +{
> +	struct ifaddrmsg *ifm;
> +	struct nlmsghdr *nlh;
> +	u8 scope;

The variable 'scope' is not used below.

Cheers,

Paolo


  parent reply	other threads:[~2024-11-21  9:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21  5:47 [PATCH net-next, v3] netlink: add IGMP/MLD join/leave notifications Yuyang Huang
2024-11-21  8:24 ` Nicolas Dichtel
2024-11-21  8:27   ` Yuyang Huang
2024-11-21  9:14 ` Paolo Abeni [this message]
2024-11-21  9:16   ` Yuyang Huang
2024-11-21 21:33 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=322e75ab-8ae8-4dd0-9646-ef41d9ff2fba@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jimictw@google.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=prohr@google.com \
    --cc=pruddy@vyatta.att-mail.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=yuyanghuang@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox