From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven Eckelmann Subject: Re: [PATCH v2 3/5] batman: use BIT_ULL for NL80211_STA_INFO_* attribute types Date: Thu, 14 Jun 2018 12:40:47 +0200 Message-ID: <32533954.9n15W0HXMB@bentobox> References: <1528971137-432-1-git-send-email-omer.efrat@tandemg.com> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1894910.JER9txcFyR"; micalg="pgp-sha512"; protocol="application/pgp-signature" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Omer Efrat Return-path: In-Reply-To: <1528971137-432-1-git-send-email-omer.efrat-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org --nextPart1894910.JER9txcFyR Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Donnerstag, 14. Juni 2018 13:12:17 CEST Omer Efrat wrote: > Since 'filled' member in station_info changed to u64, BIT_ULL macro > should be used with NL80211_STA_INFO_* attribute types instead of BIT. > > The BIT macro uses unsigned long type which some architectures handle as 32bit > and this results in compilation warnings such as: > > net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type > sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS); > ^ > > Signed-off-by: Omer Efrat > --- > net/batman-adv/bat_v_elp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) It is called "batman-adv" and not "batman". And when (as in commit) did it change to 64 bit? Shouldn't there be a "Fixed: " line to know which kernels are affected (especially for the stable kernel developers). Kind regards, Sven --nextPart1894910.JER9txcFyR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlsiRi8ACgkQXYcKB8Em e0YbyQ/+My4yzF1oi/pXLfsQ5ZowyM1a3YffYUmbjwas2LAli29aMCFeESnB14qO bpoiFHbfJw0F3+hBRrJ0+/mc73MBi5V/YStIIamWGpilNaxGjlQ+QzlM2nQWqXGm RByQ6/1M/JTsLMc9+QpBy2kNMQC/Upq6kFeMLlramvHO9x1UjudUJx9PFzX/2AnD vJzSRwo5wa4+7ugUzgeRiZWRydIXn2kbrwvWjlzFY/Y0z6F/YgdyNOmrW9NGNFLL lblfLP81rSFwXi18rxOpHVwAuQ/OLoYwboQwxSQgec1oVHV35vHBQOyqs1qLE1Wz RXi3aFi5uKiTXoTwoC7HToU5Hah8M3lJBk+Rp8LrOgp8BNJe2nkxa9QDj2djj2Xi cIojNYGWNpeGhxy73IITHwLh+llpRMEBtejmkmRGxMboj+NiIXNRnDqwxkVoksxW Hz6zCmNrooFtLhfx8YPzaMjicsuQ9rV2A9aO2pE6mmgqrnaiontXUUyP7I5cMfOf PfcO0Eu1BECFDU7EwVJPTn71+6gtP6zIqzrwZQ1+OQ4Tb9txrBseHWqjqiumk5Eu dxwkTwYTBqeQO4Vxm+r7GBJse5FdAMrgqvFwjh1taFX4fYkTo6OzddjY2+v6gRec 6PYZs6YveYYymeNJbUoWbSNzUIWRmGelU/pKapz6d5j/k4a70Cc= =e0XQ -----END PGP SIGNATURE----- --nextPart1894910.JER9txcFyR--