From: Florian Fainelli <f.fainelli@gmail.com>
To: Asmaa Mnebhi <asmaa@nvidia.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, olteanv@gmail.com
Cc: netdev@vger.kernel.org, davthompson@nvidia.com
Subject: Re: [PATCH v3 3/3] mlxbf_gige: Enable the GigE port in mlxbf_gige_open
Date: Fri, 22 Sep 2023 10:48:01 -0700 [thread overview]
Message-ID: <3279f31e-a81a-454c-b3b2-b0dc1559fa85@gmail.com> (raw)
In-Reply-To: <20230922173626.23790-4-asmaa@nvidia.com>
On 9/22/2023 10:36 AM, Asmaa Mnebhi wrote:
> At the moment, the GigE port is enabled in the mlxbf_gige_probe
> function. If the mlxbf_gige_open is not executed, this could cause
> pause frames to increase in the case where there is high backgroud
> traffic. This results in clogging the port.
> So move enabling the OOB port to mlxbf_gige_open.
>
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
> Reviewed-by: David Thompson <davthompson@nvidia.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
prev parent reply other threads:[~2023-09-22 17:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 17:36 [PATCH v3 0/3] mlxbf_gige: Fix several bugs Asmaa Mnebhi
2023-09-22 17:36 ` [PATCH v3 1/3] mlxbf_gige: Fix kernel panic at shutdown Asmaa Mnebhi
2023-09-22 17:44 ` Florian Fainelli
2023-10-13 14:58 ` Asmaa Mnebhi
2024-01-05 16:05 ` Asmaa Mnebhi
2023-09-22 17:36 ` [PATCH v3 2/3] mlxbf_gige: Fix intermittent no ip issue Asmaa Mnebhi
2023-09-22 17:47 ` Florian Fainelli
2023-10-13 15:00 ` Asmaa Mnebhi
2023-10-16 17:45 ` Asmaa Mnebhi
2023-09-22 17:36 ` [PATCH v3 3/3] mlxbf_gige: Enable the GigE port in mlxbf_gige_open Asmaa Mnebhi
2023-09-22 17:48 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3279f31e-a81a-454c-b3b2-b0dc1559fa85@gmail.com \
--to=f.fainelli@gmail.com \
--cc=asmaa@nvidia.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).