From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH 0/4] RFC CPSW switchdev mode
Date: Tue, 5 Jun 2018 16:18:22 -0500
Message-ID: <327df2cb-a0ad-c272-9b03-066d16ac14b6@ti.com>
References: <1527144984-31236-1-git-send-email-ilias.apalodimas@linaro.org>
 <20180524080528.GD2295@nanopsycho> <20180524084831.GA2759@apalos>
 <20180524125431.GB24557@lunn.ch>
 <7437d485-1eac-9619-3827-5af9b32b939e@redhat.com>
 <20180524140831.GA16793@apalos> <2b3cabca-4710-0a71-69c7-cc433e2b3062@ti.com>
 <20180603000831.GA14515@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>, <netdev@vger.kernel.org>,
        <ivan.khoronzhuk@linaro.org>, <nsekhar@ti.com>,
        <francois.ozog@linaro.org>, <yogeshs@ti.com>, <spatton@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from fllnx209.ext.ti.com ([198.47.19.16]:51179 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752731AbeFEVSg (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Jun 2018 17:18:36 -0400
In-Reply-To: <20180603000831.GA14515@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/02/2018 07:08 PM, Andrew Lunn wrote:
> On Sat, Jun 02, 2018 at 06:28:22PM -0500, Grygorii Strashko wrote:
> 
> Hi Grygorii
> 
> I'm just picking out one thing here... there is lots more good stuff here.
> 
>> Additional headache is PTP: we have on PHC, but both external interfaces P1/P2
>> can timestamp packets.
>   
> This should not be a problem. The Marvell switches have one PHC, but
> each port can time stamp packets using this counter. Each port has its
> own receive and transmit time stamp registers. So i don't think this
> will cause you problems.

I hope you are right - question is always in number of available options
and which one to select - and, most important, explain it to the end user :( 


For example:
phc_index is returned as part of .get_ts_info() = cpsw_get_ts_info(),
so which intf should return phc_index?

Still not tested, so jut hope ...


-- 
regards,
-grygorii