From: Daniel Borkmann <daniel@iogearbox.net>
To: Anders Roxell <anders.roxell@linaro.org>, ast@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/bpf/syscall: fix warning defined but not used
Date: Wed, 4 Apr 2018 11:15:29 +0200 [thread overview]
Message-ID: <327e3c1f-860b-e2b4-7475-34a409c62fae@iogearbox.net> (raw)
In-Reply-To: <20180403120947.9321-1-anders.roxell@linaro.org>
On 04/03/2018 02:09 PM, Anders Roxell wrote:
> There will be a build warning -Wunused-function if CONFIG_CGROUP_BPF
> isn't defined, since the only user is inside #ifdef CONFIG_CGROUP_BPF:
> kernel/bpf/syscall.c:1229:12: warning: ‘bpf_prog_attach_check_attach_type’
> defined but not used [-Wunused-function]
> static int bpf_prog_attach_check_attach_type(const struct bpf_prog *prog,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Current code moves function bpf_prog_attach_check_attach_type inside
> ifdef CONFIG_CGROUP_BPF.
>
> Fixes: 5e43f899b03a ("bpf: Check attach type at prog load time")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Applied to bpf tree, thanks Anders!
prev parent reply other threads:[~2018-04-04 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 12:09 [PATCH] kernel/bpf/syscall: fix warning defined but not used Anders Roxell
2018-04-04 9:15 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=327e3c1f-860b-e2b4-7475-34a409c62fae@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=anders.roxell@linaro.org \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox