From: Tariq Toukan <tariqt@nvidia.com>
To: Simon Horman <horms@kernel.org>, Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: Remove redundant memset after kvzalloc
Date: Mon, 19 Oct 2026 21:44:01 +0300 [thread overview]
Message-ID: <327efca9-7df1-437f-8040-a244111d719e@nvidia.com> (raw)
In-Reply-To: <20261018151325.GP503057@horms.kernel.org>
On 18/10/2026 18:13, Simon Horman wrote:
> On Tue, Oct 13, 2026 at 12:03:10AM +0900, Sang-Heon Jeon wrote:
>> kvzalloc() returns zeroed memory, so the memset after the allocation in
>> mlx5e_post_meter_create_mtu_table() and macsec_fs_tx_create() is
>> redundant.
>>
>> So remove the memset.
>>
>> No functional change.
>>
>> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
>
> Hi Sang-Heon,
>
> I'm not sure if the value this cleanup brings is worth the churn.
Exactly!
> But I do believe it is correct.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Anyway,
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
next prev parent reply other threads:[~2026-10-19 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 15:03 [PATCH net-next] net/mlx5: Remove redundant memset after kvzalloc Sang-Heon Jeon
2026-10-18 15:13 ` Simon Horman
2026-10-19 18:44 ` Tariq Toukan [this message]
2026-10-20 11:28 ` Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=327efca9-7df1-437f-8040-a244111d719e@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox