* [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100
@ 2022-11-30 20:12 Jonathan Toppins
2022-11-30 20:12 ` [PATCH net-next 2/2] Documentation: bonding: correct xmit hash steps Jonathan Toppins
2022-12-02 11:20 ` [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100 patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Toppins @ 2022-11-30 20:12 UTC (permalink / raw)
To: netdev
Cc: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jonathan Corbet,
Mahesh Bandewar, Jarod Wilson, linux-doc, linux-kernel
With commit c1f897ce186a ("bonding: set default miimon value for non-arp
modes if not set") the miimon default was changed from zero to 100 if
arp_interval is also zero. Document this fact in bonding.rst.
Fixes: c1f897ce186a ("bonding: set default miimon value for non-arp modes if not set")
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
Documentation/networking/bonding.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
index 96cd7a26f3d9..da57aac73ffc 100644
--- a/Documentation/networking/bonding.rst
+++ b/Documentation/networking/bonding.rst
@@ -566,7 +566,8 @@ miimon
link monitoring. A value of 100 is a good starting point.
The use_carrier option, below, affects how the link state is
determined. See the High Availability section for additional
- information. The default value is 0.
+ information. The default value is 100 if arp_interval is not
+ set.
min_links
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH net-next 2/2] Documentation: bonding: correct xmit hash steps
2022-11-30 20:12 [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100 Jonathan Toppins
@ 2022-11-30 20:12 ` Jonathan Toppins
2022-12-02 11:20 ` [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100 patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Toppins @ 2022-11-30 20:12 UTC (permalink / raw)
To: netdev
Cc: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jonathan Corbet,
linux-doc, linux-kernel
Correct xmit hash steps for layer3+4 as introduced by commit
49aefd131739 ("bonding: do not discard lowest hash bit for non layer3+4
hashing").
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
Documentation/networking/bonding.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
index da57aac73ffc..adc4bf4f3c50 100644
--- a/Documentation/networking/bonding.rst
+++ b/Documentation/networking/bonding.rst
@@ -957,6 +957,7 @@ xmit_hash_policy
hash = hash XOR source IP XOR destination IP
hash = hash XOR (hash RSHIFT 16)
hash = hash XOR (hash RSHIFT 8)
+ hash = hash RSHIFT 1
And then hash is reduced modulo slave count.
If the protocol is IPv6 then the source and destination
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100
2022-11-30 20:12 [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100 Jonathan Toppins
2022-11-30 20:12 ` [PATCH net-next 2/2] Documentation: bonding: correct xmit hash steps Jonathan Toppins
@ 2022-12-02 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-02 11:20 UTC (permalink / raw)
To: Jonathan Toppins
Cc: netdev, j.vosburgh, vfalico, andy, davem, edumazet, kuba, pabeni,
corbet, maheshb, jarod, linux-doc, linux-kernel
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 30 Nov 2022 15:12:06 -0500 you wrote:
> With commit c1f897ce186a ("bonding: set default miimon value for non-arp
> modes if not set") the miimon default was changed from zero to 100 if
> arp_interval is also zero. Document this fact in bonding.rst.
>
> Fixes: c1f897ce186a ("bonding: set default miimon value for non-arp modes if not set")
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
>
> [...]
Here is the summary with links:
- [net-next,1/2] Documentation: bonding: update miimon default to 100
https://git.kernel.org/netdev/net-next/c/f036b97da67f
- [net-next,2/2] Documentation: bonding: correct xmit hash steps
https://git.kernel.org/netdev/net-next/c/95cce3fae4d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-02 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-30 20:12 [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100 Jonathan Toppins
2022-11-30 20:12 ` [PATCH net-next 2/2] Documentation: bonding: correct xmit hash steps Jonathan Toppins
2022-12-02 11:20 ` [PATCH net-next 1/2] Documentation: bonding: update miimon default to 100 patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).