From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next v2 2/2] mlxsw: spectrum_router: Return an error for routes added after abort Date: Wed, 2 May 2018 09:28:10 -0600 Message-ID: <32c82844-73a8-77f8-f47c-eef167e53cd8@gmail.com> References: <20180502071735.32352-1-idosch@mellanox.com> <20180502071735.32352-3-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:33516 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbeEBP2M (ORCPT ); Wed, 2 May 2018 11:28:12 -0400 Received: by mail-pg0-f66.google.com with SMTP id i194-v6so10891515pgd.0 for ; Wed, 02 May 2018 08:28:12 -0700 (PDT) In-Reply-To: <20180502071735.32352-3-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/2/18 1:17 AM, Ido Schimmel wrote: > We currently do not perform accounting in the driver and thus can't > reject routes before resources are exceeded. > > However, in order to make users aware of the fact that routes are no > longer offloaded we can return an error for routes configured after the > abort mechanism was triggered. > > Signed-off-by: Ido Schimmel > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > index added380e344..8028d221aece 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > @@ -5928,6 +5928,13 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb, > router->mlxsw_sp); > if (!err || info->extack) > return notifier_from_errno(err); > + break; > + case FIB_EVENT_ENTRY_ADD: > + if (router->aborted) { > + NL_SET_ERR_MSG_MOD(info->extack, "FIB offload was aborted. Not configuring route"); > + return notifier_from_errno(-EINVAL); > + } > + break; > } > > fib_work = kzalloc(sizeof(*fib_work), GFP_ATOMIC); > Reasonable next step. Acked-by: David Ahern