From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: Re: [PATCH] ixgbe: fix Kconfig when driver is not a module Date: Fri, 04 Jan 2019 10:06:55 -0800 Message-ID: <331b34610a904d382a1aae4639e646caeacc7bce.camel@intel.com> References: <20190103213519.9754-1-jeffrey.t.kirsher@intel.com> <9484abfd-0a07-31be-c738-6b770bbd3dc4@silicom-usa.com> Reply-To: jeffrey.t.kirsher@intel.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-0U+aTcPh2MvsY0KclIHM" Cc: "netdev@vger.kernel.org" , Dave Jones , Florian Fainelli To: Steve Douthit , "intel-wired-lan@lists.osuosl.org" Return-path: Received: from mga04.intel.com ([192.55.52.120]:52662 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfADSG6 (ORCPT ); Fri, 4 Jan 2019 13:06:58 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: --=-0U+aTcPh2MvsY0KclIHM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-01-04 at 15:09 +0000, Steve Douthit wrote: > On 1/3/19 7:55 PM, Jeff Kirsher wrote: > > I initially tried that, but we get a recursive Kconfig dependency > > error > > when IPSec is enabled as well, which I noted in the commit message. > I'm not running into the dependency issue you mention in my own > testing > of the 'select PHYLIB' patch. All of the following configurations > build > for me with no issues: >=20 > 0 1 2 3 4 5 > CONFIG_IXGBE m m m m y y > CONFIG_IXGBE_IPSEC n y n y n y > CONFIG_MDIO_BUS m m y y y y > CONFIG_PHYLIB m m y y y y >=20 > I also confirmed that I can't have CONFIG_MDIO_BUS=3Dm and > CONFIG_IXGBE=3Dy. > Setting CONFIG_IXGBE=3Dy forces CONFIG_MDIO_BUS=3Dy. >=20 > Base config I started with is here: https://pastebin.com/yFsiRRQZ > That's the config 0 from above, the only diff to the other configs > was > to set the appropriate symbol to 'y'. >=20 > I also tested against the config Dave posted (accepting fixdep > defaults) > and that also worked. >=20 > What am I missing here? >=20 > Can you post the config you were using that had the dependency > problem > with CONFIG_IXGBE_IPSEC? I was using 'make allmodconfig' and then altering CONFIG_IXGBE=3Dy to get the error, but it appears that you are correct. Using select PHYLIB or imply PHYLIB does resolve the problem. I am wondering through all the iterations of testing, I somehow missed using either of those. I swore I had tested those and got this error: drivers/dma/Kconfig:5:error: recursive dependency detected! drivers/dma/Kconfig:5: symbol DMADEVICES is selected by CRYPTO_DEV_SP_CCP drivers/crypto/ccp/Kconfig:9: symbol CRYPTO_DEV_SP_CCP depends on CRYPTO crypto/Kconfig:16: symbol CRYPTO is selected by XFRM_ALGO net/xfrm/Kconfig:13: symbol XFRM_ALGO is selected by IXGBE_IPSEC drivers/net/ethernet/intel/Kconfig:204: symbol IXGBE_IPSEC depends on IXGBE drivers/net/ethernet/intel/Kconfig:158: symbol IXGBE depends on PHYLIB drivers/net/phy/Kconfig:181: symbol PHYLIB is selected by ARC_EMAC_CORE drivers/net/ethernet/arc/Kconfig:18: symbol ARC_EMAC_CORE is selected by ARC_EMAC drivers/net/ethernet/arc/Kconfig:24: symbol ARC_EMAC depends on OF_IRQ drivers/of/Kconfig:68: symbol OF_IRQ depends on IRQ_DOMAIN kernel/irq/Kconfig:63: symbol IRQ_DOMAIN is selected by IRQ_DOMAIN_HIERARCHY kernel/irq/Kconfig:72: symbol IRQ_DOMAIN_HIERARCHY is selected by GENERIC_MSI_IRQ_DOMAIN kernel/irq/Kconfig:89: symbol GENERIC_MSI_IRQ_DOMAIN is selected by MV_XOR_V2 drivers/dma/Kconfig:379: symbol MV_XOR_V2 depends on DMADEVICES For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" make[2]: *** [scripts/kconfig/Makefile:69: syncconfig] Error 1 make[1]: *** [Makefile:544: syncconfig] Error 2 make: *** [Makefile:640: include/config/auto.conf] Error 2 But now I only get that when I use: depends on PHYLIB Since you suggestion is much simply, I will go with your suggestion.=20 Expect a v3, with your simplified solution. --=-0U+aTcPh2MvsY0KclIHM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlwvoL8ACgkQ5W/vlVpL 7c4Dvw//TdzB806ax2TkkwFiTWvcizjoJD1KKoRnPwNAeG07i3Kez7cigqxyWnAV SijG9znU+MpxuwSuSejbdRJxvL10dZaAw/4sSYLITn6A4n/xirwts9VpzwYRyauW 17SxygAyPDQXxumzn2q3kdNNfDpHjDUHyiu/5UgkVP2oJm7K8yr/9o2048AbcdMw FZvcez6FoyyqPiOg8n7Y4B2eY61yPKpN0hBuPAwx7XErew2U9uBfFE3DwcTgUCNy kO4lSeDtgDM9lYNbtfqBQU8Yqp7JQB7IoUXJH5INN5rWiOgtbSzXMuxeHZpe0rY1 CMOgyxJ3IPzv35PTUIwp2l6KFhRR0365jJLX/gve9L7lO+QeTkLvuKtCJRwEdmfY 5bSYla5TsTmyTMi1FYcKOr6p9u8fyVlbEAJZqtxWr2TeodsMgkVx1UzCnqhTG82/ MfUiOOaOMNsi+zv6JCMfT0574EP1nX92b5oB/cwQ2Omw5tg39UNqpiYaS1hsM6pS jYiYh67iyLWDTm++2S/v5VH40gASMmE5izo/wnXGIb9dZQQCziT+WCZMZ1vn3hZ8 Hr20AgIwhSGHnmFakAmRLIbJwpQJhR+JaFrwZtyqDEU630+fojFWW1C1GOtxIP0A Po1E5MRMZ7MY0rYL4HTF/K84hu5EwIireDuPUrOg0QLa0qpNMvY= =ADMG -----END PGP SIGNATURE----- --=-0U+aTcPh2MvsY0KclIHM--