From: Dan Carpenter <dan.carpenter@linaro.org>
To: Simon Horman <horms@kernel.org>
Cc: James Chapman <jchapman@katalix.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org,
tparkin@katalix.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next] l2tp: remove unneeded null check in l2tp_v2_session_get_next
Date: Tue, 3 Sep 2024 11:02:32 +0300 [thread overview]
Message-ID: <332ef891-510e-4382-804c-bc2245276ea7@stanley.mountain> (raw)
In-Reply-To: <20240903072417.GN23170@kernel.org>
On Tue, Sep 03, 2024 at 08:24:17AM +0100, Simon Horman wrote:
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/r/202408111407.HtON8jqa-lkp@intel.com/
> > CC: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: James Chapman <jchapman@katalix.com>
> > Signed-off-by: Tom Parkin <tparkin@katalix.com>
>
> And as you posted the patch, it would be slightly more intuitive
> if your SoB line came last. But I've seen conflicting advice about
> the order of tags within the past weeks.
It should be in chronological order.
People generally aren't going to get too fussed about the order except the
Signed-off-by tags. Everyone who handles the patch adds their Signed-off-by to
the end. Right now it looks like James wrote the patch and then Tom is the
maintainer who merged it. Co-developed-by?
regards,
dan carpenter
next prev parent reply other threads:[~2024-09-03 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 14:29 [PATCH net-next] l2tp: remove unneeded null check in l2tp_v2_session_get_next James Chapman
2024-09-03 7:24 ` Simon Horman
2024-09-03 8:02 ` Dan Carpenter [this message]
2024-09-03 10:48 ` James Chapman
2024-09-03 11:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=332ef891-510e-4382-804c-bc2245276ea7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox