From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6B28254850 for ; Thu, 17 Apr 2025 16:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744908066; cv=none; b=Fb2F6pR3UWpB5JO+vnqwtnf3pvhvatP2nwHdHIdlR8WbNsOt2Q5FBrzSMHt9Kb0GhQfgShbZLG/M0vM0D55AEwTd+etyJUH2VEZ54AU5Mj2l1jGJsCCFdpUPluRSlDx0qAHzejsd4zgFngmb+PsXHV7/fFfGVmizUTNy8IPSa0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744908066; c=relaxed/simple; bh=Cmws64+ZxMzbbyNXTYJucL/4NmPbYEAODTkS40Qb4zk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U1EDdVzbXNzsWmZhOX07crasQHP7L0d5yJFc8wmhej/YIi0/KSaTkJYA04xzq3Lsq50SLOgn8e8qrKHUVH+Ycc8WkXnP7MwaatXuCAUU3g1ZjFUuDAs1ba+DrwiRTAorvyROoVbkN0+82IHeTmJzN2Zqic1XDeM2KLZIlaVpKkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RGjKPy+c; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RGjKPy+c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744908063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MVkVweXyhN8uWsQkQsYLwmRjnYv2NnfH0NHhh2MVCeo=; b=RGjKPy+cJ/4A6Z3oor5vF42894pnqi7UEujV+cqXR1rAb7mKfjUZgijIci+FgMsx1TKpE1 vZsNfCnAweqWxihMmQUl2XU22Zrod+kXgX4FzQc0H/ZFK5Ep7T2KWGDm3zcOuZP6ELp7uX pNyMQN6+bX5+NfPPOPmK7p5Kod8BT7Q= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-l4RkTimuPlqyfjeKFpSTMQ-1; Thu, 17 Apr 2025 12:40:55 -0400 X-MC-Unique: l4RkTimuPlqyfjeKFpSTMQ-1 X-Mimecast-MFC-AGG-ID: l4RkTimuPlqyfjeKFpSTMQ_1744908052 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 920691801BD5; Thu, 17 Apr 2025 16:40:50 +0000 (UTC) Received: from [10.44.33.28] (unknown [10.44.33.28]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DBC6B30002C2; Thu, 17 Apr 2025 16:40:45 +0000 (UTC) Message-ID: <335003db-49e5-4501-94e5-4e9c6994be7d@redhat.com> Date: Thu, 17 Apr 2025 18:40:44 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 net-next 8/8] mfd: zl3073x: Register DPLL sub-device during init To: Lee Jones Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Kees Cook , Andy Shevchenko , Andrew Morton , Michal Schmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250416162144.670760-1-ivecera@redhat.com> <20250416162144.670760-9-ivecera@redhat.com> <20250417162044.GG372032@google.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20250417162044.GG372032@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 17. 04. 25 6:20 odp., Lee Jones wrote: > On Wed, 16 Apr 2025, Ivan Vecera wrote: > >> Register DPLL sub-devices to expose this functionality provided >> by ZL3073x chip family. Each sub-device represents one of the provided >> DPLL channels. >> >> Signed-off-by: Ivan Vecera >> --- >> drivers/mfd/zl3073x-core.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c >> index 0bd31591245a2..fda77724a8452 100644 >> --- a/drivers/mfd/zl3073x-core.c >> +++ b/drivers/mfd/zl3073x-core.c >> @@ -6,6 +6,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -774,6 +775,20 @@ int zl3073x_dev_probe(struct zl3073x_dev *zldev, >> if (rc) >> return rc; >> >> + /* Add DPLL sub-device cell for each DPLL channel */ >> + for (i = 0; i < chip_info->num_channels; i++) { >> + struct mfd_cell dpll_dev = MFD_CELL_BASIC("zl3073x-dpll", NULL, >> + NULL, 0, i); > > Create a static one of these with the maximum amount of channels. Like this? static const struct mfd_cell dpll_cells[] = { MFD_CELL_BASIC("zl3073x-dpll", NULL, NULL, 0, 1), MFD_CELL_BASIC("zl3073x-dpll", NULL, NULL, 0, 2), MFD_CELL_BASIC("zl3073x-dpll", NULL, NULL, 0, 3), MFD_CELL_BASIC("zl3073x-dpll", NULL, NULL, 0, 4), MFD_CELL_BASIC("zl3073x-dpll", NULL, NULL, 0, 5), }; rc = devm_mfd_add_devices(zldev->dev, PLATFORM_DEVID_AUTO, dpll_cells, chip_info->num_channels, NULL, 0, NULL); Ivan > >> + >> + rc = devm_mfd_add_devices(zldev->dev, PLATFORM_DEVID_AUTO, >> + &dpll_dev, 1, NULL, 0, NULL); > > Then pass chip_info->num_channels as the 4th argument. > >> + if (rc) { >> + dev_err_probe(zldev->dev, rc, >> + "Failed to add DPLL sub-device\n"); >> + return rc; >> + } >> + } >> + >> /* Register the device as devlink device */ >> devlink = priv_to_devlink(zldev); >> devlink_register(devlink); >> -- >> 2.48.1 >> >