From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Victor Nogueira <victor@mojatatu.com>
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes
Date: Mon, 15 Sep 2025 15:14:41 -0700 [thread overview]
Message-ID: <3365174.1757974481@famine> (raw)
In-Reply-To: <20250912154616.67489-1-victor@mojatatu.com>
Victor Nogueira <victor@mojatatu.com> wrote:
>For the tc police action, iproute2 rounds up mtu and burst sizes to a
>higher order representation. For example, if the user specifies the default
>mtu for a police action instance (4294967295 bytes), iproute2 will output
>it as 4096Mb when this action instance is dumped. After Jay's changes [1],
>iproute2 will round up to Gb, so 4096Mb becomes 4Gb. With that in mind,
>fix police's tc test output so that it works both with the current
>iproute2 version and Jay's.
>
>[1] https://lore.kernel.org/netdev/20250907014216.2691844-1-jay.vosburgh@canonical.com/
>
>Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>---
> tools/testing/selftests/tc-testing/tc-tests/actions/police.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>index 5596f4df0e9f..b2cc6ea74450 100644
>--- a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>@@ -879,7 +879,7 @@
> "cmdUnderTest": "$TC actions add action police pkts_rate 1000 pkts_burst 200 index 1",
> "expExitCode": "0",
> "verifyCmd": "$TC actions ls action police",
>- "matchPattern": "action order [0-9]*: police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200",
>+ "matchPattern": "action order [0-9]*: police 0x1 rate 0bit burst 0b mtu (4Gb|4096Mb) pkts_rate 1000 pkts_burst 200",
> "matchCount": "1",
> "teardown": [
> "$TC actions flush action police"
>--
>2.51.0
>
next prev parent reply other threads:[~2025-09-15 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 15:46 [PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes Victor Nogueira
2025-09-14 5:06 ` Cong Wang
2025-09-15 22:14 ` Jay Vosburgh [this message]
2025-09-15 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3365174.1757974481@famine \
--to=jay.vosburgh@canonical.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).