[PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes

[PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes

[Victor Nogueira]

For the tc police action, iproute2 rounds up mtu and burst sizes to a
higher order representation. For example, if the user specifies the default
mtu for a police action instance (4294967295 bytes), iproute2 will output
it as 4096Mb when this action instance is dumped. After Jay's changes [1],
iproute2 will round up to Gb, so 4096Mb becomes 4Gb. With that in mind,
fix police's tc test output so that it works both with the current
iproute2 version and Jay's.

[1] https://lore.kernel.org/netdev/20250907014216.2691844-1-jay.vosburgh@canonical.com/

Signed-off-by: Victor Nogueira <victor@mojatatu.com>
---
 tools/testing/selftests/tc-testing/tc-tests/actions/police.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
index 5596f4df0e9f..b2cc6ea74450 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
@@ -879,7 +879,7 @@
         "cmdUnderTest": "$TC actions add action police pkts_rate 1000 pkts_burst 200 index 1",
         "expExitCode": "0",
         "verifyCmd": "$TC actions ls action police",
-        "matchPattern": "action order [0-9]*:  police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200",
+        "matchPattern": "action order [0-9]*:  police 0x1 rate 0bit burst 0b mtu (4Gb|4096Mb) pkts_rate 1000 pkts_burst 200",
         "matchCount": "1",
         "teardown": [
             "$TC actions flush action police"
-- 
2.51.0

Re: [PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes

[Cong Wang]

On Fri, Sep 12, 2025 at 8:46 AM Victor Nogueira <victor@mojatatu.com> wrote:
>
> For the tc police action, iproute2 rounds up mtu and burst sizes to a
> higher order representation. For example, if the user specifies the default
> mtu for a police action instance (4294967295 bytes), iproute2 will output
> it as 4096Mb when this action instance is dumped. After Jay's changes [1],
> iproute2 will round up to Gb, so 4096Mb becomes 4Gb. With that in mind,
> fix police's tc test output so that it works both with the current
> iproute2 version and Jay's.
>
> [1] https://lore.kernel.org/netdev/20250907014216.2691844-1-jay.vosburgh@canonical.com/
>
> Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Reviewed-by: Cong Wang <cwang@multikernel.io>

Thanks!

Re: [PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes

[Jay Vosburgh]

Victor Nogueira <victor@mojatatu.com> wrote:

>For the tc police action, iproute2 rounds up mtu and burst sizes to a
>higher order representation. For example, if the user specifies the default
>mtu for a police action instance (4294967295 bytes), iproute2 will output
>it as 4096Mb when this action instance is dumped. After Jay's changes [1],
>iproute2 will round up to Gb, so 4096Mb becomes 4Gb. With that in mind,
>fix police's tc test output so that it works both with the current
>iproute2 version and Jay's.
>
>[1] https://lore.kernel.org/netdev/20250907014216.2691844-1-jay.vosburgh@canonical.com/
>
>Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>


>---
> tools/testing/selftests/tc-testing/tc-tests/actions/police.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>index 5596f4df0e9f..b2cc6ea74450 100644
>--- a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>@@ -879,7 +879,7 @@
>         "cmdUnderTest": "$TC actions add action police pkts_rate 1000 pkts_burst 200 index 1",
>         "expExitCode": "0",
>         "verifyCmd": "$TC actions ls action police",
>-        "matchPattern": "action order [0-9]*:  police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200",
>+        "matchPattern": "action order [0-9]*:  police 0x1 rate 0bit burst 0b mtu (4Gb|4096Mb) pkts_rate 1000 pkts_burst 200",
>         "matchCount": "1",
>         "teardown": [
>             "$TC actions flush action police"
>-- 
>2.51.0
>

Re: [PATCH net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 12 Sep 2025 12:46:16 -0300 you wrote:
> For the tc police action, iproute2 rounds up mtu and burst sizes to a
> higher order representation. For example, if the user specifies the default
> mtu for a police action instance (4294967295 bytes), iproute2 will output
> it as 4096Mb when this action instance is dumped. After Jay's changes [1],
> iproute2 will round up to Gb, so 4096Mb becomes 4Gb. With that in mind,
> fix police's tc test output so that it works both with the current
> iproute2 version and Jay's.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests/tc-testing: Adapt tc police action tests for Gb rounding changes
    https://git.kernel.org/netdev/net-next/c/b7df2e7eaef7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html