From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next 1/3] dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings Date: Tue, 17 Oct 2017 13:14:51 +0300 Message-ID: <337f227a-3019-4e82-a0cb-1328d7036df7@cogentembedded.com> References: <20171017074747.24159-1-horms+renesas@verge.net.au> <20171017074747.24159-2-horms+renesas@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: Simon Horman , David Miller Return-path: Received: from mail-lf0-f43.google.com ([209.85.215.43]:49726 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757627AbdJQKOy (ORCPT ); Tue, 17 Oct 2017 06:14:54 -0400 Received: by mail-lf0-f43.google.com with SMTP id w21so1359272lfc.6 for ; Tue, 17 Oct 2017 03:14:53 -0700 (PDT) In-Reply-To: <20171017074747.24159-2-horms+renesas@verge.net.au> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 10/17/2017 10:47 AM, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen 1 and 2. > > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship > between IP blocks might be. For example, I believe that r8a7790 is older > than r8a7791 but that doesn't imply that the latter is a descendant of the > former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Note that R-Car Gen2 and RZ/G1 have many compatible IP blocks. The > approach that has been consistently taken for other IP blocks is to name > common code, compatibility strings and so on after Rcar Gen2. > > Signed-off-by: Simon Horman Reviewed-by: Sergei Shtylyov > --- > Documentation/devicetree/bindings/net/sh_eth.txt | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/sh_eth.txt b/Documentation/devicetree/bindings/net/sh_eth.txt > index 0115c85a2425..48cab94dd056 100644 > --- a/Documentation/devicetree/bindings/net/sh_eth.txt > +++ b/Documentation/devicetree/bindings/net/sh_eth.txt > @@ -4,7 +4,8 @@ This file provides information on what the device node for the SH EtherMAC > interface contains. > > Required properties: > -- compatible: "renesas,gether-r8a7740" if the device is a part of R8A7740 SoC. > +- compatible: Must contain one or more of the following: > + "renesas,gether-r8a7740" if the device is a part of R8A7740 SoC. > "renesas,ether-r8a7743" if the device is a part of R8A7743 SoC. > "renesas,ether-r8a7745" if the device is a part of R8A7745 SoC. > "renesas,ether-r8a7778" if the device is a part of R8A7778 SoC. > @@ -14,6 +15,14 @@ Required properties: > "renesas,ether-r8a7793" if the device is a part of R8A7793 SoC. > "renesas,ether-r8a7794" if the device is a part of R8A7794 SoC. > "renesas,ether-r7s72100" if the device is a part of R7S72100 SoC. > + "renesas,rcar-gen1-ether" for a generic R-Car Gen1 device. > + "renesas,rcar-gen2-ether" for a generic R-Car Gen2 or RZ/G1 > + device. > + > + When compatible with the generic version nodes must list > + the SoC-specific version corresponding to the platform > + first followed by the generic version. > + The original text uses the different indentation, tab and then spaces), while you use only spaces here (but not above). > - reg: offset and length of (1) the E-DMAC/feLic register block (required), > (2) the TSU register block (optional). > - interrupts: interrupt specifier for the sole interrupt. > @@ -36,7 +45,8 @@ Optional properties: > Example (Lager board): > > ethernet@ee700000 { > - compatible = "renesas,ether-r8a7790"; > + compatible = "renesas,ether-r8a7790", > + "renesas,rcar-gen2-ether"; Again, using one more tab seems possible here... > reg = <0 0xee700000 0 0x400>; > interrupt-parent = <&gic>; > interrupts = <0 162 IRQ_TYPE_LEVEL_HIGH>; > MBR, Sergei