From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info Date: Tue, 04 Dec 2012 17:22:46 +0800 Message-ID: <33871315.gHWf0QtYzd@jason-thinkpad-t430s> References: <1354011360-39479-1-git-send-email-jasowang@redhat.com> <3524590.ZWGua7A8ne@jason-thinkpad-t430s> <20121203111848.GD26167@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20121203111848.GD26167@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Monday, December 03, 2012 01:18:48 PM Michael S. Tsirkin wrote: > On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote: > > > > + > > > > > > > > + /* Work struct for refilling if we run low on memory. */ > > > > > > > > + struct delayed_work refill; > > > > > > I can't really see the justificaiton for a refill per queue. Just have > > > > > > one work iterate all the queues if it happens, unless it happens often > > > > > > (in which case, we need to look harder at this anyway). > > > > But during this kind of iteration, we may need enable/disable the napi > > regardless of whether the receive queue has lots to be refilled. This may > > add extra latency. > > We are running from the timer, so latency is not a concern I think. Maybe, anyway it's only called when avaiable memory is low, so it should not be an issue.