From: Richard Cochran <richardcochran@gmail.com>
To: netdev@vger.kernel.org
Cc: devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
David Miller <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: [PATCH net-next RFC V1 3/5] net: Introduce field for the MII time stamper.
Date: Wed, 21 Mar 2018 11:58:16 -0700 [thread overview]
Message-ID: <338f19a006839f1d00e3cfd3521bdd5fd0afc5fe.1521656774.git.richardcochran@gmail.com> (raw)
In-Reply-To: <cover.1521656774.git.richardcochran@gmail.com>
This patch adds a new field to the network device structure to reference
a time stamping device on the MII bus. By decoupling the time stamping
function from the PHY device, we pave the way to allowing a non-PHY
device to take this role.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/phy/mdio_bus.c | 51 +++++++++++++++++++++++++++++++++++++++++++++-
include/linux/netdevice.h | 1 +
2 files changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 24b5511222c8..fdac8c8ac272 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -717,6 +717,47 @@ static int mdio_uevent(struct device *dev, struct kobj_uevent_env *env)
return 0;
}
+static bool mdiodev_supports_timestamping(struct mdio_device *mdiodev)
+{
+ if (mdiodev->ts_info && mdiodev->hwtstamp &&
+ mdiodev->rxtstamp && mdiodev->txtstamp)
+ return true;
+ else
+ return false;
+}
+
+static int mdiobus_netdev_notification(struct notifier_block *nb,
+ unsigned long msg, void *ptr)
+{
+ struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
+ struct phy_device *phydev = netdev->phydev;
+ struct mdio_device *mdev;
+ struct mii_bus *bus;
+ int i;
+
+ if (netdev->mdiots || msg != NETDEV_UP || !phydev)
+ return NOTIFY_DONE;
+
+ /*
+ * Examine the MII bus associated with the PHY that is
+ * attached to the MAC. If there is a time stamping device
+ * on the bus, then connect it to the network device.
+ */
+ bus = phydev->mdio.bus;
+
+ for (i = 0; i < PHY_MAX_ADDR; i++) {
+ mdev = bus->mdio_map[i];
+ if (!mdev)
+ continue;
+ if (mdiodev_supports_timestamping(mdev)) {
+ netdev->mdiots = mdev;
+ return NOTIFY_OK;
+ }
+ }
+
+ return NOTIFY_DONE;
+}
+
#ifdef CONFIG_PM
static int mdio_bus_suspend(struct device *dev)
{
@@ -772,6 +813,10 @@ struct bus_type mdio_bus_type = {
};
EXPORT_SYMBOL(mdio_bus_type);
+static struct notifier_block mdiobus_netdev_notifier __read_mostly = {
+ .notifier_call = mdiobus_netdev_notification,
+};
+
int __init mdio_bus_init(void)
{
int ret;
@@ -782,14 +827,18 @@ int __init mdio_bus_init(void)
if (ret)
class_unregister(&mdio_bus_class);
}
+ if (ret)
+ return ret;
+
+ return register_netdevice_notifier(&mdiobus_netdev_notifier);
- return ret;
}
EXPORT_SYMBOL_GPL(mdio_bus_init);
#if IS_ENABLED(CONFIG_PHYLIB)
void mdio_bus_exit(void)
{
+ unregister_netdevice_notifier(&mdiobus_netdev_notifier);
class_unregister(&mdio_bus_class);
bus_unregister(&mdio_bus_type);
}
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 5fbb9f1da7fd..223d691aa0b0 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1943,6 +1943,7 @@ struct net_device {
struct netprio_map __rcu *priomap;
#endif
struct phy_device *phydev;
+ struct mdio_device *mdiots;
struct lock_class_key *qdisc_tx_busylock;
struct lock_class_key *qdisc_running_key;
bool proto_down;
--
2.11.0
next prev parent reply other threads:[~2018-03-21 18:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 18:58 [PATCH net-next RFC V1 0/5] Peer to Peer One-Step time stamping Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 1/5] net: Introduce peer to peer one step PTP " Richard Cochran
2018-03-21 20:05 ` Keller, Jacob E
2018-03-21 21:26 ` Richard Cochran
2018-03-21 23:51 ` Keller, Jacob E
2018-03-21 18:58 ` [PATCH net-next RFC V1 2/5] net: phy: Move time stamping interface into the generic mdio layer Richard Cochran
2018-03-21 19:10 ` Florian Fainelli
2018-03-21 21:45 ` Richard Cochran
2018-03-24 16:59 ` Richard Cochran
2018-03-21 18:58 ` Richard Cochran [this message]
2018-03-21 19:12 ` [PATCH net-next RFC V1 3/5] net: Introduce field for the MII time stamper Florian Fainelli
2018-03-21 21:51 ` Richard Cochran
2018-03-24 17:01 ` Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 4/5] net: Use the generic MII time stamper when available Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core Richard Cochran
2018-03-21 19:33 ` Andrew Lunn
2018-03-21 21:36 ` Richard Cochran
2018-03-21 21:44 ` Andrew Lunn
2018-03-21 21:57 ` Richard Cochran
2018-03-21 22:16 ` Andrew Lunn
2018-03-21 22:47 ` Richard Cochran
2018-03-21 23:50 ` Andrew Lunn
2018-03-24 17:12 ` Richard Cochran
2018-03-24 18:48 ` Andrew Lunn
2018-03-25 4:51 ` Richard Cochran
2018-03-25 15:59 ` Andrew Lunn
2018-03-25 22:10 ` Richard Cochran
2018-03-25 23:01 ` Florian Fainelli
2018-04-03 3:55 ` Richard Cochran
2018-04-03 13:13 ` Andrew Lunn
2018-04-03 15:02 ` Richard Cochran
2018-03-25 23:01 ` Andrew Lunn
2018-04-03 4:27 ` Richard Cochran
2018-03-25 23:06 ` Andrew Lunn
2018-03-25 22:14 ` Richard Cochran
2018-03-22 0:43 ` Andrew Lunn
2018-03-22 1:57 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=338f19a006839f1d00e3cfd3521bdd5fd0afc5fe.1521656774.git.richardcochran@gmail.com \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).