From: David Howells <dhowells@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dhowells@redhat.com, Christian Brauner <brauner@kernel.org>,
Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, linux-fsdevel@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records
Date: Fri, 28 Feb 2025 14:45:18 +0000 [thread overview]
Message-ID: <3399367.1740753918@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250228062216.77e34415@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
> fs/afs/cell.c:203:5-22: WARNING: Unsigned expression compared with zero: cell -> dynroot_ino < 0
I'll make this change:
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -200,7 +200,7 @@ static struct afs_cell *afs_alloc_cell(struct afs_net *net,
atomic_inc(&net->cells_outstanding);
cell->dynroot_ino = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
2, INT_MAX / 2, GFP_KERNEL);
- if (cell->dynroot_ino < 0)
+ if ((int)cell->dynroot_ino < 0)
goto error;
cell->debug_id = atomic_inc_return(&cell_debug_id);
to patch 2 ("afs: Change dynroot to create contents on demand").
I'm not sure why gcc didn't warn about this - I'm sure it used to.
David
next prev parent reply other threads:[~2025-02-28 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 8:58 [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records David Howells
2025-02-28 10:31 ` Christian Brauner
2025-02-28 14:22 ` Jakub Kicinski
2025-02-28 14:33 ` David Howells
2025-02-28 14:45 ` David Howells [this message]
2025-03-01 13:23 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3399367.1740753918@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).