From: Yonghong Song <yhs@fb.com>
To: Peter Zijlstra <peterz@infradead.org>, Alexei Starovoitov <ast@fb.com>
Cc: <mingo@kernel.org>, <daniel@iogearbox.net>,
<linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<kernel-team@fb.com>, Thomas Gleixner <tglx@linutronix.de>,
netdev <netdev@vger.kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH] x86/cpufeature: guard asm_volatile_goto usage with CC_HAVE_ASM_GOTO
Date: Sat, 14 Apr 2018 13:30:56 -0700 [thread overview]
Message-ID: <339b047f-7886-967b-08e0-703cd892de30@fb.com> (raw)
In-Reply-To: <20180414101112.GX4064@hirez.programming.kicks-ass.net>
On 4/14/18 3:11 AM, Peter Zijlstra wrote:
> On Fri, Apr 13, 2018 at 01:42:14PM -0700, Alexei Starovoitov wrote:
>> On 4/13/18 11:19 AM, Peter Zijlstra wrote:
>>> On Tue, Apr 10, 2018 at 02:28:04PM -0700, Alexei Starovoitov wrote:
>>>> Instead of
>>>> #ifdef CC_HAVE_ASM_GOTO
>>>> we can replace it with
>>>> #ifndef __BPF__
>>>> or some other name,
>>>
>>> I would prefer the BPF specific hack; otherwise we might be encouraging
>>> people to build the kernel proper without asm-goto.
>>>
>>
>> I don't understand this concern.
>
> The thing is; this will be a (temporary) BPF specific hack. Hiding it
> behind something that looks 'normal' (CC_HAVE_ASM_GOTO) is just not
> right.
This is a fair concern. I will use a different macro and send v2 soon.
Thanks.
prev parent reply other threads:[~2018-04-14 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180410204259.3981586-1-yhs@fb.com>
[not found] ` <20180410210716.GI4082@hirez.programming.kicks-ass.net>
[not found] ` <552d5866-912e-afde-f25a-77ae8390816d@fb.com>
[not found] ` <20180413181924.GT4064@hirez.programming.kicks-ass.net>
2018-04-13 20:42 ` [PATCH] x86/cpufeature: guard asm_volatile_goto usage with CC_HAVE_ASM_GOTO Alexei Starovoitov
2018-04-14 10:11 ` Peter Zijlstra
2018-04-14 20:30 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339b047f-7886-967b-08e0-703cd892de30@fb.com \
--to=yhs@fb.com \
--cc=ast@fb.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox