From: David Ahern <dsahern@gmail.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: netdev@vger.kernel.org, sashal@kernel.org, mmanning@vyatta.att-mail.com
Subject: Re: Why revert commit 2271c95 ("vrf: mark skb for multicast or link-local as enslaved to VRF")?
Date: Sun, 18 Oct 2020 19:53:42 -0600 [thread overview]
Message-ID: <33c7f9b3-aec6-6327-53b3-3b54f74ddcf6@gmail.com> (raw)
In-Reply-To: <20201018160624.GB11729@ICIPI.localdomain>
On 10/18/20 10:06 AM, Stephen Suryaputra wrote:
> $ git --no-pager show afed1a4
>
> commit afed1a4dbb76c81900f10fd77397fb91ad442702
> Author: Sasha Levin <sashal@kernel.org>
> Date: Mon Mar 23 16:21:31 2020 -0400
>
> Revert "vrf: mark skb for multicast or link-local as enslaved to VRF"
>
> This reverts commit 2271c9500434af2a26b2c9eadeb3c0b075409fb5.
>
> This patch shouldn't have been backported to 4.14.
>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
My response last November was:
'backporting this patch and it's bug fix, "ipv6: Fix handling of LLA
with VRF and sockets bound to VRF" to 4.14 is a bit questionable. They
definitely do not need to come back to 4.9.'
Basically, my point is that this is work that was committed to 4.19-next
I believe and given the state of the VRF feature over the releases, I
could not confirm for 4.14 that everything works as intended. Hence, the
comment about it being questionable.
If you / your company are actively using and testing VRF on 4.14 and can
confirm it works, then I am fine with the patch (and its bugfix) getting
applied.
next prev parent reply other threads:[~2020-10-19 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 13:24 Why revert commit 2271c95 ("vrf: mark skb for multicast or link-local as enslaved to VRF")? Stephen Suryaputra
2020-10-18 15:27 ` David Ahern
2020-10-18 16:06 ` Stephen Suryaputra
2020-10-19 1:53 ` David Ahern [this message]
2020-10-19 12:04 ` Mike Manning
2020-10-19 12:24 ` Mike Manning
2020-10-19 12:38 ` Stephen Suryaputra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c7f9b3-aec6-6327-53b3-3b54f74ddcf6@gmail.com \
--to=dsahern@gmail.com \
--cc=mmanning@vyatta.att-mail.com \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).