From: David Ahern <dsahern@gmail.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] fib_semantics: Fix warning in fib_check_nh_v4_gw
Date: Mon, 17 Jun 2019 11:12:10 -0600 [thread overview]
Message-ID: <33c98309-a8d2-ecfe-7385-72769a571d9b@gmail.com> (raw)
In-Reply-To: <20190617102119.56253-1-vincenzo.frascino@arm.com>
On 6/17/19 4:21 AM, Vincenzo Frascino wrote:
> Currently, the err variable in fib_check_nh_v4_gw may be used
> uninitialized leading to the warning below:
>
> fib_semantics.c: In function ‘fib_check_nh_v4_gw’:
> fib_semantics.c:1023:12: warning: ‘err’ may be used
> uninitialised in this function [-Wmaybe-uninitialized]
> if (!tbl || err) {
> ^~
>
> Initialize err to 0 to fix the warning.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> net/ipv4/fib_semantics.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
already fixed in net; will make it to net-next on next merge.
prev parent reply other threads:[~2019-06-17 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 10:21 [PATCH] fib_semantics: Fix warning in fib_check_nh_v4_gw Vincenzo Frascino
2019-06-17 17:12 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c98309-a8d2-ecfe-7385-72769a571d9b@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).