From: Paolo Abeni <pabeni@redhat.com>
To: Sam Edwards <cfsworks@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Linux Network Development Mailing List <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] ipv6/addrconf: fix timing bug in tempaddr regen
Date: Fri, 03 Jun 2022 19:13:49 +0200 [thread overview]
Message-ID: <33ceb9b576c98cf0fae1d37a3a95f534975410a6.camel@redhat.com> (raw)
In-Reply-To: <CAH5Ym4iS=d+dUAg+85wmRJv+jV=Cet=UtN1pNWejMV5fdPVprA@mail.gmail.com>
On Thu, 2022-06-02 at 23:02 -0600, Sam Edwards wrote:
> Since this is a periodic routine, it receives coverage as the system
> runs normally. If we're concerned about protecting this change from
> regressions and/or through the merge process, some kind of automated
> test might be in order, but right now the way to test it is to leave
> the system up, with tempaddrs enabled, on a IPv6 SLAAC network, for
> several multiples of the temp_prefered_lft.
It does not look easy, but you could use kunit to create e.g. a
temporary address on the loopback device with the critical expiration
time setting and check that it's deleted in due time - possibly after
tuning the defaults to a reasonably short period.
The above will additionally open-up opportunities for more autoconf
tests.
Up to your good will ;)
Thanks
Paolo
prev parent reply other threads:[~2022-06-03 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 0:48 [PATCH v2] ipv6/addrconf: fix timing bug in tempaddr regen Sam Edwards
2022-05-31 7:50 ` Paolo Abeni
2022-06-03 5:02 ` Sam Edwards
2022-06-03 17:13 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33ceb9b576c98cf0fae1d37a3a95f534975410a6.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=cfsworks@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).