From: Paolo Abeni <pabeni@redhat.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH RFC 3/3] udp: Support UDP fraglist GRO/GSO.
Date: Sat, 26 Jan 2019 10:36:40 +0100 [thread overview]
Message-ID: <33fac48cd79c98b1da7af20f04c5acef9b740ce3.camel@redhat.com> (raw)
In-Reply-To: <20190125075855.GT3581@gauss3.secunet.de>
On Fri, 2019-01-25 at 08:58 +0100, Steffen Klassert wrote:
> > Finally this will cause GRO/GSO for local UDP packets delivery to non
> > GSO_SEGMENT sockets. That could be possibly a win or a regression: we
> > save on netfilter/IP stack traversal, but we add additional work, some
> > performances figures would probably help.
>
> I did some tests for the local receive path with netperf and iperf, but
> in this case the sender that generates the packets is the bottleneck.
> So the benchmarks are not that meaningful for the receive path.
I think we can use GSO on the sender if we add some additional code on
the rx side - for testing purpose only - limiting the GRO aggregation
to an (user controlled via sysfs) value.
Beyond that, other options would be using multiple senders threads and
a single rx queue and/or asymmetric CPUs.
> Do you have some performance tests for UDP GRO receive?
I have a bunch of ansible(!!!) scripts I can share, if you dare. They
have a lot of hard-coded setting, so I'm not sure how much can be re-
used outside my testbed.
I also hope/wish/think/ I can allocate some time for benchmarking this
on my own in the next week[s], so I'll try to post some results for the
next iteration.
Cheers,
Paolo
next prev parent reply other threads:[~2019-01-26 9:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 7:53 [PATCH RFC 0/3] Support fraglist GRO/GSO Steffen Klassert
2018-12-21 7:53 ` [PATCH RFC 1/3] net: Prepare GSO return values for fraglist GSO Steffen Klassert
2019-01-08 13:53 ` Paolo Abeni
2019-01-14 12:53 ` Steffen Klassert
2018-12-21 7:53 ` [PATCH RFC 2/3] net: Support GRO/GSO fraglist chaining Steffen Klassert
2018-12-21 7:53 ` [PATCH RFC 3/3] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-01-08 15:00 ` Paolo Abeni
2019-01-25 7:58 ` Steffen Klassert
2019-01-26 9:36 ` Paolo Abeni [this message]
2019-01-28 8:09 ` Steffen Klassert
2018-12-24 1:15 ` [PATCH RFC 0/3] Support " Willem de Bruijn
2018-12-26 13:09 ` Marcelo Ricardo Leitner
2019-01-14 12:50 ` Steffen Klassert
2019-01-14 17:09 ` Willem de Bruijn
2019-01-25 8:14 ` Steffen Klassert
2019-01-25 13:57 ` Willem de Bruijn
2019-01-28 7:51 ` Steffen Klassert
2019-01-28 16:46 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33fac48cd79c98b1da7af20f04c5acef9b740ce3.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason@zx2c4.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).