From: "J. K. Cliburn" <jcliburn@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: atl1-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] atlx: duplicate testing of MCAST flag
Date: Sun, 12 Jul 2009 19:04:20 -0500 [thread overview]
Message-ID: <3400f2f60907121704s105ba16bqebcdb75bc855888e@mail.gmail.com> (raw)
In-Reply-To: <4A5A6DE5.4090801@gmail.com>
On Sun, Jul 12, 2009 at 6:12 PM, Roel Kluin<roel.kluin@gmail.com> wrote:
> Fix duplicate testing of MCAST flag
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I think the first should be UCAST, correct?
>
> diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c
> index c734b19..204db96 100644
> --- a/drivers/net/atlx/atl2.c
> +++ b/drivers/net/atlx/atl2.c
> @@ -2071,7 +2071,7 @@ static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE))
> return -EOPNOTSUPP;
>
> - if (wol->wolopts & (WAKE_MCAST|WAKE_BCAST|WAKE_MCAST))
> + if (wol->wolopts & (WAKE_UCAST | WAKE_BCAST | WAKE_MCAST))
> return -EOPNOTSUPP;
>
> /* these settings will always override what we currently have */
>
Acked-by: Jay Cliburn <jcliburn@gmail.com>
next prev parent reply other threads:[~2009-07-13 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 23:12 [PATCH] atlx: duplicate testing of MCAST flag Roel Kluin
2009-07-13 0:04 ` J. K. Cliburn [this message]
2009-07-13 18:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3400f2f60907121704s105ba16bqebcdb75bc855888e@mail.gmail.com \
--to=jcliburn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=atl1-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox