From: Jay Vosburgh <fubar@us.ibm.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Or Gerlitz <ogerlitz@Voltaire.com>,
eilong@broadcom.com, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [net-next 6/10] bnx2x: Update vlan_features
Date: Fri, 24 Jul 2009 12:47:16 -0700 [thread overview]
Message-ID: <3426.1248464836@death.nxdomain.ibm.com> (raw)
In-Reply-To: <4A68479F.1000807@trash.net>
Patrick McHardy <kaber@trash.net> wrote:
>In case of bonding, its necessary to update vlan_features so it
>contains the intersection of all underlying devices. But a
>change will only take effect for existing VLANs (f.i. when
>enslaving a new device) if you call netdev_features_change().
Patrick, can you clarify one bit about your above statment? You
say the bonding features should be an "intersection"; is that a strict
intersection (i.e., slave1->vlan_features | slave2->vlan_features), or
does the NETIF_F_ONE_FOR_ALL logic apply for vlan_features as it does
for regular dev->features (using netdev_incrmenet_features() to combine
the feature sets)?
In other words, if a bond has two slaves, one with, e.g.,
NETIF_F_SG in its vlan_features, and the other slave has 0 in
vlan_features, should the bond's vlan_features be NETIF_F_SG, or 0?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2009-07-24 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 15:47 [net-next 6/10] bnx2x: Update vlan_features Eilon Greenstein
2009-07-23 10:46 ` Patrick McHardy
2009-07-23 11:14 ` Or Gerlitz
2009-07-23 11:21 ` Patrick McHardy
2009-07-23 11:30 ` Or Gerlitz
2009-07-23 18:47 ` Jay Vosburgh
2009-07-24 19:47 ` Jay Vosburgh [this message]
2009-08-26 14:18 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3426.1248464836@death.nxdomain.ibm.com \
--to=fubar@us.ibm.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@Voltaire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).