From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available Date: Tue, 19 Dec 2017 11:42:33 -0800 Message-ID: <344f0afc-b4aa-9f1a-15b8-166ba97d270b@intel.com> References: <20171219174259-mutt-send-email-mst@kernel.org> <20171219095548.61d70d10@xeon-e3> <20171219.132117.666798483874609477.davem@davemloft.net> <20171219104159.30d9caaf@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, alexander.duyck@gmail.com, jesse.brandeburg@intel.com To: Stephen Hemminger , David Miller Return-path: Received: from mga07.intel.com ([134.134.136.100]:1456 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbdLSTmd (ORCPT ); Tue, 19 Dec 2017 14:42:33 -0500 In-Reply-To: <20171219104159.30d9caaf@xeon-e3> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Tue, 19 Dec 2017 09:55:48 -0800 >> >>> could be 10ms, just enough to let udev do its renaming >> Please, move to some kind of notification or event based handling of >> this problem. >> >> No delay is safe, what if userspace gets swapped out or whatever >> else might make userspace stall unexpectedly? >> > The plan is to remove the delay and do the naming in the kernel. > This was suggested by Lennart since udev is only doing naming policy > because kernel names were not repeatable. > > This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. > > Patch is pending. Do we really need to delay the setup until the name is changed? Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? Thanks Sridhar