From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH 1/2] net: asix: init ASIX AX88772B MAC from EEPROM Date: Tue, 18 Dec 2012 14:56 +0100 Message-ID: <3452375.BatShodvFL@linux-lqwf.site> References: <1355832626-3034-1-git-send-email-dev@lynxeye.de> <1672154.FXjtO9OFRj@linux-lqwf.site> <1355837912.1490.73.camel@tellur> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org To: Lucas Stach Return-path: Received: from cantor2.suse.de ([195.135.220.15]:45410 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173Ab2LRNzb (ORCPT ); Tue, 18 Dec 2012 08:55:31 -0500 In-Reply-To: <1355837912.1490.73.camel@tellur> Sender: netdev-owner@vger.kernel.org List-ID: On Tuesday 18 December 2012 14:38:32 Lucas Stach wrote: > Am Dienstag, den 18.12.2012, 14:33 +0100 schrieb Oliver Neukum: > > On Tuesday 18 December 2012 14:24:32 Lucas Stach wrote: > > > Am Dienstag, den 18.12.2012, 14:11 +0100 schrieb Oliver Neukum: > > > > On Tuesday 18 December 2012 13:10:25 Lucas Stach wrote: > > > > > diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h > > > > > index 9bbeabf..8e9516f 100644 > > > > > --- a/include/linux/usb/usbnet.h > > > > > +++ b/include/linux/usb/usbnet.h > > > > > @@ -106,6 +106,7 @@ struct driver_info { > > > > > */ > > > > > #define FLAG_MULTI_PACKET 0x2000 > > > > > #define FLAG_RX_ASSEMBLE 0x4000 /* rx packets may span >1 frames */ > > > > > +#define FLAG_EEPROM_MAC 0x8000 /* initialize device MAC from eeprom */ > > > > > > > > Hi, > > > > > > > > this looks sensible, but > > > > why are you adding a flag unused in usbnet to usbnet.h? > > > > > > Right, this might not be the right place to add this. Could you point me > > > to a more appropriate place? The data member of usbnet might be a good > > > > driver_priv is intended for such stuff > > > I'm not talking about the usbnet struct, but the driver_info struct. I > need a way to pass this flag from the static driver info to the bind > function. I don't even have a usbnet device at this point, where I could > hang on driver_priv data. True, sorry I misread the patch. You could split up ax88772_bind() implicitly encoding the flag. That would be reasonably clean. If you really don't want to do that, please add another private field. But we cannot pollute the flags. Regards Oliver