From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
linux-sctp@vger.kernel.org
Subject: [PATCH net-next 5/6] sctp: do not clear chunk->ecn_ce_done flag
Date: Wed, 13 Jul 2016 15:08:59 -0300 [thread overview]
Message-ID: <349cf5fdf54449cf16097503d5200f60ae388a65.1468432819.git.marcelo.leitner@gmail.com> (raw)
In-Reply-To: <cover.1468432819.git.marcelo.leitner@gmail.com>
We should not clear that flag when switching to a new skb from a GSO skb
because it would cause ECN processing to happen multiple times per GSO
skb, which is not wanted. Instead, let it be processed once per chunk.
That is, in other words, once per IP header available.
Fixes: 90017accff61 ("sctp: Add GSO support")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
net/sctp/inqueue.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sctp/inqueue.c b/net/sctp/inqueue.c
index 8fc773f9b59a8a9ad123dd132cfa5b7f916732b6..942770675f4cc0efc9686f4e4038450f060f34ae 100644
--- a/net/sctp/inqueue.c
+++ b/net/sctp/inqueue.c
@@ -217,7 +217,6 @@ new_skb:
chunk->auth = 0;
chunk->has_asconf = 0;
chunk->end_of_packet = 0;
- chunk->ecn_ce_done = 0;
if (chunk->head_skb) {
struct sctp_input_cb
*cb = SCTP_INPUT_CB(chunk->skb),
--
2.7.4
next prev parent reply other threads:[~2016-07-13 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 18:08 [PATCH net-next 0/6] sctp: allow GSO frags to access the chunk too Marcelo Ricardo Leitner
2016-07-13 18:08 ` [PATCH net-next 1/6] sctp: allow others to use sctp_input_cb Marcelo Ricardo Leitner
2016-07-13 18:08 ` [PATCH net-next 2/6] sctp: reorder sctp_ulpevent and shrink msg_flags Marcelo Ricardo Leitner
2016-07-13 18:08 ` [PATCH net-next 3/6] sctp: allow GSO frags to access the chunk too Marcelo Ricardo Leitner
2016-07-13 18:08 ` [PATCH net-next 4/6] sctp: avoid identifying address family many times for a chunk Marcelo Ricardo Leitner
2016-07-13 18:08 ` Marcelo Ricardo Leitner [this message]
2016-07-13 18:09 ` [PATCH net-next 6/6] sctp: only check for ECN if peer is using it Marcelo Ricardo Leitner
2016-07-14 1:10 ` [PATCH net-next 0/6] sctp: allow GSO frags to access the chunk too David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=349cf5fdf54449cf16097503d5200f60ae388a65.1468432819.git.marcelo.leitner@gmail.com \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).