From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] dsa: bcm_sf2: Initialize __be16 with a __be16 value
Date: Sun, 5 Jul 2020 13:38:12 -0700 [thread overview]
Message-ID: <34eb76ec-2c0c-64d8-fb9c-100000eb4edf@gmail.com> (raw)
In-Reply-To: <20200705203625.891900-3-andrew@lunn.ch>
On 7/5/2020 1:36 PM, Andrew Lunn wrote:
> A __be16 variable should be initialised with a __be16 value. So add a
> htons(). In this case it is pointless, given the value being assigned
> is 0xffff, but it stops sparse from warnings.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
The subject should be:
net: dsa: bcm_sf2: Initialize __be16 with a __be16 value
to be consistent with other commits done to the same file, with that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-05 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 20:36 [PATCH net-next 0/3] dsa: b53/sf2 Andrew Lunn
2020-07-05 20:36 ` [PATCH net-next 1/3] net: dsa: b53: Fixup endianness warnings Andrew Lunn
2020-07-05 20:38 ` Florian Fainelli
2020-07-05 20:36 ` [PATCH net-next 2/3] dsa: bcm_sf2: Initialize __be16 with a __be16 value Andrew Lunn
2020-07-05 20:38 ` Florian Fainelli [this message]
2020-07-05 20:36 ` [PATCH net-next 3/3] dsa: bmc_sf2: Pass GENMASK() signed bits Andrew Lunn
2020-07-05 20:39 ` Florian Fainelli
2020-07-05 22:46 ` [PATCH net-next 0/3] dsa: b53/sf2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34eb76ec-2c0c-64d8-fb9c-100000eb4edf@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).