From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Tariq Toukan <tariqt@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,
Brenden Blanco <bblanco@plumgrid.com>
Subject: Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme
Date: Sun, 30 Oct 2016 18:03:06 +0200 [thread overview]
Message-ID: <34ee2e3e-a2ad-2104-9444-ae9c7fed55b7@gmail.com> (raw)
In-Reply-To: <20161028010701.GB49550@ast-mbp.thefacebook.com>
On 28/10/2016 4:07 AM, Alexei Starovoitov wrote:
> On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote:
>> Separately manage the two types of TX rings: regular ones, and XDP.
>> Upon an XDP set, do not borrow regular TX rings and convert them
>> into XDP ones, but allocate new ones, unless we hit the max number
>> of rings.
>> Which means that in systems with smaller #cores we will not consume
>> the current TX rings for XDP, while we are still in the num TX limit.
> The commit log is too scarce for details...
> So questions:
> - Did you test with changing the number of channels after xdp prog is loaded?
> That was the recent bug that Brenden fixed.
Bug no longer exists, as the indices of the XDP TX rings now start from
0, each is identical to its respective RX ring.
Brenden's fix didn't get to net-next yet, and it shouldn't once the
series is applied.
I need to take this w Dave.
> - does it still have 256 tx queue limit or xdp tx rings can go over?
It still has the limit of 256 TX queues.
> - Any performance implications ?
I didn't see any performance implications.
Note that the XDP TX rings are no longer shown in ethtool -S.
>
> Brenden, could you please review this patch?
>
Regards,
Tariq
next prev parent reply other threads:[~2016-10-30 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 14:52 [PATCH net-next 0/2] mlx4 XDP TX refactor Tariq Toukan
2016-10-27 14:52 ` [PATCH net-next 1/2] net/mlx4_en: Add TX_XDP for CQ types Tariq Toukan
2016-10-27 14:52 ` [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme Tariq Toukan
2016-10-28 1:07 ` Alexei Starovoitov
2016-10-29 23:18 ` Brenden Blanco
2016-10-30 16:03 ` Tariq Toukan [this message]
2016-10-30 22:44 ` Alexei Starovoitov
2016-10-30 23:11 ` Saeed Mahameed
2016-10-30 23:21 ` Saeed Mahameed
2016-10-30 16:21 ` [PATCH net-next 0/2] mlx4 XDP TX refactor Tariq Toukan
2016-10-30 16:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34ee2e3e-a2ad-2104-9444-ae9c7fed55b7@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).