From: Paolo Abeni <pabeni@redhat.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v1 3/3] net: dsa: microchip: Fix PHY loopback configuration for KSZ8794 and KSZ8873
Date: Thu, 23 Nov 2023 11:52:57 +0100 [thread overview]
Message-ID: <35045f6ef6a5b274063186c065a8215088b94cd5.camel@redhat.com> (raw)
In-Reply-To: <20231121152426.4188456-3-o.rempel@pengutronix.de>
Hi,
On Tue, 2023-11-21 at 16:24 +0100, Oleksij Rempel wrote:
> Correct the PHY loopback bit handling in the ksz8_w_phy_bmcr and
> ksz8_r_phy_bmcr functions for KSZ8794 and KSZ8873 variants in the ksz8795
> driver. Previously, the code erroneously used Bit 7 of port register 0xD
> for both chip variants, which is actually for LED configuration. This
> update ensures the correct registers and bits are used for the PHY
> loopback feature:
>
> - For KSZ8794: Use 0xF / Bit 7.
> - For KSZ8873: Use 0xD / Bit 0.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This looks like a bugfix, so possibly worth a Fixes tag? Given the
dependency on the previous refactor, I think we can take it via net-
next.
@Andrew, Florian, Vladimir: do you have any specific preference here?
Thanks!
Paolo
next prev parent reply other threads:[~2023-11-23 10:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:24 [PATCH net-next v1 1/3] net: dsa: microchip: ksz8: move BMCR specific code to separate function Oleksij Rempel
2023-11-21 15:24 ` [PATCH net-next v1 2/3] net: dsa: microchip: Remove redundant optimization in ksz8_w_phy_bmcr Oleksij Rempel
2023-11-23 10:54 ` Paolo Abeni
2023-12-06 22:37 ` Vladimir Oltean
2023-11-21 15:24 ` [PATCH net-next v1 3/3] net: dsa: microchip: Fix PHY loopback configuration for KSZ8794 and KSZ8873 Oleksij Rempel
2023-11-23 10:52 ` Paolo Abeni [this message]
2023-12-06 8:55 ` Oleksij Rempel
2023-12-06 15:14 ` Vladimir Oltean
2023-12-06 15:54 ` Oleksij Rempel
2023-12-06 16:43 ` Vladimir Oltean
2023-12-07 0:28 ` Vladimir Oltean
2023-12-07 5:15 ` Oleksij Rempel
2023-12-07 14:00 ` Vladimir Oltean
2023-12-20 9:46 ` Oleksij Rempel
2023-12-06 16:46 ` [PATCH net-next v1 1/3] net: dsa: microchip: ksz8: move BMCR specific code to separate function Vladimir Oltean
2023-12-07 4:57 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35045f6ef6a5b274063186c065a8215088b94cd5.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).