From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: Only honor ifindex in IP_PKTINFO if non-0
Date: Fri, 16 Feb 2018 15:12:08 -0700 [thread overview]
Message-ID: <351e22cd-2a8c-497f-584f-cef88e522ab2@gmail.com> (raw)
In-Reply-To: <20180216.164316.1601719296881855600.davem@davemloft.net>
On 2/16/18 2:43 PM, David Miller wrote:
> From: David Ahern <dsahern@gmail.com>
> Date: Fri, 16 Feb 2018 11:03:03 -0800
>
>> Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings
>> if the index is actually set in the message.
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>
> Ok, this behavior meets reasonable expectations, applied, thanks.
>
> None of the documation is clear about this relationship between
> ip_pktinfo's ifindex and settings made by SO_BINDTODEVICE.
>
It is my understanding that SO_BINDTODEVICE is the strongest -- it
requires admin to set. From there IP_PKTINFO and IP_UNICAST_IF are
non-root options and hence weaker. If that is the proper expectation,
then the right thing to do is probably to error out if ipc.oif is
already set. I was concerned that would break existing apps, so this
seemed to be a compromise.
next prev parent reply other threads:[~2018-02-16 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 19:03 [PATCH net-next] net: Only honor ifindex in IP_PKTINFO if non-0 David Ahern
2018-02-16 21:43 ` David Miller
2018-02-16 22:12 ` David Ahern [this message]
2018-03-06 20:52 ` David Ahern
2018-03-06 21:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=351e22cd-2a8c-497f-584f-cef88e522ab2@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).