From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] net/ipv6: do not copy DST_NOCOUNT flag on rt init Date: Thu, 13 Sep 2018 21:11:22 -0700 Message-ID: <351e6fbc-5356-b5c1-0638-0554843ad833@gmail.com> References: <20180913203814.189698-1-posk@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Peter Oskolkov , David Miller , netdev@vger.kernel.org Return-path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:44427 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbeINJYA (ORCPT ); Fri, 14 Sep 2018 05:24:00 -0400 Received: by mail-pl1-f196.google.com with SMTP id ba4-v6so3558574plb.11 for ; Thu, 13 Sep 2018 21:11:26 -0700 (PDT) In-Reply-To: <20180913203814.189698-1-posk@google.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/13/18 1:38 PM, Peter Oskolkov wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 3eed045c65a5..a3902f805305 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -946,7 +946,7 @@ static void ip6_rt_init_dst_reject(struct rt6_info *rt, struct fib6_info *ort) > > static void ip6_rt_init_dst(struct rt6_info *rt, struct fib6_info *ort) > { > - rt->dst.flags |= fib6_info_dst_flags(ort); > + rt->dst.flags |= fib6_info_dst_flags(ort) & ~DST_NOCOUNT; I think my mistake is setting dst.flags in ip6_rt_init_dst. Flags argument is passed to ip6_dst_alloc which is always invoked before ip6_rt_copy_init is called which is the only caller of ip6_rt_init_dst. > > if (ort->fib6_flags & RTF_REJECT) { > ip6_rt_init_dst_reject(rt, ort); >