From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency Date: Fri, 10 Feb 2017 09:42:21 -0800 Message-ID: <352146cc-845c-2860-44ca-7338eb53e260@gmail.com> References: <20170209150834.1158193-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Jason Cooper , Networking , Russell King , Linux Kernel Mailing List , Gregory Clement , "David S . Miller" , Linux ARM , Sebastian Hesselbarth To: Arnd Bergmann Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 02/10/2017 12:20 AM, Arnd Bergmann wrote: > On Thu, Feb 9, 2017 at 7:22 PM, Florian Fainelli wrote: >> On 02/09/2017 07:08 AM, Arnd Bergmann wrote: >> I disabled CONFIG_NETDEVICES to force CONFIG_PHY not to be set here, and >> I was not able to reproduce this, what am I missing? > > In the ARMv5 allmodconfig build, this fails because CONFIG_PHY=m, and > we can't call into it. You could use IS_BUILTIN instead of IS_ENABLED in > the header as a oneline workaround, but I think that would be more confusing > to real users that try to use CONFIG_PHY=m without realizing why they lose > access to their switch. I see, this patch should also help fixing this: http://patchwork.ozlabs.org/patch/726381/ -- Florian