From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH 2/2] Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find." Date: Fri, 5 Jan 2018 17:12:59 +0100 Message-ID: <35230e77-dbda-1e2b-6396-41afbbaf1557@6wind.com> References: <1510826440-19452-1-git-send-email-steffen.klassert@secunet.com> <1510826440-19452-3-git-send-email-steffen.klassert@secunet.com> <20171223092217.4wbnjhpw2itbzaty@gauss3.secunet.de> <20171223.105612.1264946295573777970.davem@davemloft.net> <20171223160938.rmfwopbmeyepndh5@gauss3.secunet.de> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: herbert@gondor.apana.org.au, robsonde@gmail.com, netdev@vger.kernel.org To: Steffen Klassert , David Miller Return-path: Received: from mail-wm0-f41.google.com ([74.125.82.41]:36486 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbeAEQNE (ORCPT ); Fri, 5 Jan 2018 11:13:04 -0500 Received: by mail-wm0-f41.google.com with SMTP id b76so3388640wmg.1 for ; Fri, 05 Jan 2018 08:13:03 -0800 (PST) In-Reply-To: <20171223160938.rmfwopbmeyepndh5@gauss3.secunet.de> Content-Language: fr Sender: netdev-owner@vger.kernel.org List-ID: Le 23/12/2017 à 17:09, Steffen Klassert a écrit : > On Sat, Dec 23, 2017 at 10:56:12AM -0500, David Miller wrote: >> From: Steffen Klassert >> Date: Sat, 23 Dec 2017 10:22:17 +0100 >> >>> On Thu, Nov 16, 2017 at 11:00:40AM +0100, Steffen Klassert wrote: >>>> This reverts commit c9f3f813d462c72dbe412cee6a5cbacf13c4ad5e. >>>> >>>> This commit breaks transport mode when the policy template >>>> has widlcard addresses configured, so revert it. >>>> >>>> Signed-off-by: Steffen Klassert >>> >>> David, can you please queue this one up for v4.14-stable? >>> Commit ID is 94802151894d482e82c324edf2c658f8e6b96508 >>> >>> v4.14 is unusable for some people without this revert. >> >> Yes, but it adds back the stack out-of-bounds bug. >> >> If I queue up the revert, I would also need to queue up whatever >> follow-on you used to fix the out-of-bounds bug properly. Which >> commit is that? > > This is commit ddc47e4404b58f03e98345398fb12d38fe291512 > ("xfrm: Fix stack-out-of-bounds read on socket policy lookup.") > > It is included in the pull request for the net tree that > I sent yesterday. The patch looks save, but not so sure > if it should go directly to stable. These bugs reported by > the syzbot are usually quite subtile and I already broke > something when I tried to fix the original stack out-of-bounds > bug. So maybe we should wait until the v4.15 release before > backporting... > This patch is still missing in the 4.14 stable. Without it, some IPsec scenarii are broken. Is there a plan to queue this patch for the 4.14 stable ? Thank you, Nicolas