From: Dan Jurgens <danielj@nvidia.com>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>,
netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
alex.williamson@redhat.com, pabeni@redhat.com
Cc: virtualization@lists.linux.dev, parav@nvidia.com,
shshitrit@nvidia.com, yohadt@nvidia.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
shameerali.kolothum.thodi@huawei.com, jgg@ziepe.ca,
kevin.tian@intel.com, kuba@kernel.org, andrew+netdev@lunn.ch,
edumazet@google.com
Subject: Re: [External] : [PATCH net-next v4 01/12] virtio_pci: Remove supported_cap size build assert
Date: Mon, 13 Oct 2025 12:57:03 -0500 [thread overview]
Message-ID: <3530d46e-68c5-4966-923e-943da2f45fbd@nvidia.com> (raw)
In-Reply-To: <d1720c75-3d56-4040-b7ac-97c399302257@oracle.com>
On 10/13/25 11:38 AM, ALOK TIWARI wrote:
>
>
> On 10/13/2025 8:57 PM, Daniel Jurgens wrote:
>> The cap ID list can be more than 64 bits. Remove the build assert. Also
>> remove caching of the supported caps, it wasn't used.
>> - if (!(vp_dev->admin_vq.supported_caps & (1 <<
>> VIRTIO_DEV_PARTS_CAP)))
>> + if (!(le64_to_cpu(data->support_caps[0]) & (1 <<
>> VIRTIO_DEV_PARTS_CAP)))
>
> typo support_caps -> supported_caps ?
>
Thanks Alok, I dropped a patch before submitting that fixed this
problem, not that it could have been left this way anyway.
I've added this, and the comments on 0004 for v5.
next prev parent reply other threads:[~2025-10-13 17:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 15:27 [PATCH net-next v4 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 01/12] virtio_pci: Remove supported_cap size build assert Daniel Jurgens
2025-10-13 16:38 ` [External] : " ALOK TIWARI
2025-10-13 17:57 ` Dan Jurgens [this message]
2025-10-14 5:28 ` kernel test robot
2025-10-14 7:04 ` kernel test robot
2025-10-13 15:27 ` [PATCH net-next v4 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2025-10-13 16:25 ` [External] : " ALOK TIWARI
2025-10-13 15:27 ` [PATCH net-next v4 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-10-14 6:32 ` kernel test robot
2025-10-13 15:27 ` [PATCH net-next v4 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-10-13 15:27 ` [PATCH net-next v4 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3530d46e-68c5-4966-923e-943da2f45fbd@nvidia.com \
--to=danielj@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).