From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E03FC61DA3 for ; Tue, 21 Feb 2023 09:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233979AbjBUJjt (ORCPT ); Tue, 21 Feb 2023 04:39:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233962AbjBUJjs (ORCPT ); Tue, 21 Feb 2023 04:39:48 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0BB424497 for ; Tue, 21 Feb 2023 01:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676972338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T373vQv/bScNDxJBPlPsndv81C2bk1FJ2KP5pg5qs/Y=; b=e07k5uclJjEfNEdvv9ao4d6rLvlBakLPL0FrKZ4Pn9qGPEh0LgK5UwM4CkliqJQ+w6GZOO CRUflqomUQ92N9GGjdFqFea9MNb3LUnmOHOzfRct7+P/9wBnveaZ5UJM6NFqOqeSUPzPWO XmldxTimxObG+Z7Hktw2fJdiYc2m4Pc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-493-qKiUuS6-Ob-Zj9zqBznKrA-1; Tue, 21 Feb 2023 04:38:57 -0500 X-MC-Unique: qKiUuS6-Ob-Zj9zqBznKrA-1 Received: by mail-qk1-f197.google.com with SMTP id c9-20020ae9e209000000b0073b344eb74dso1286222qkc.10 for ; Tue, 21 Feb 2023 01:38:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T373vQv/bScNDxJBPlPsndv81C2bk1FJ2KP5pg5qs/Y=; b=tRwbb4j3D0pp7kJk0MK4/Ccv4fvKUPxw0igmKXDqFpN06iPgj5U3CDqXKNgWSPO91X NKG/7gyGcIdsxnK0/wBYOjliisdW1qMPI7XFLuYEZQciNUr3B1fzIgKUM8tTETCzh4yN Ux2PwiG4arP4+bT1Ko/gri8bjZ0nW4/dCDa6NBCWA0HiV9rVPdH2194s2KmQdOIu+Xty gifKOQfJ16ULUosHCN1OJ4G/gKUh3SWr/6ME+LugRzL/hksNFd+DTQYbJO/0/awefocS M4t4k/cNC7mI0xadVQB/EjYaHZnWVXbZf1+sTXjvP3S58fxU3c44H7HHSqGm9d/aqe70 QerQ== X-Gm-Message-State: AO0yUKXkSiPwHqzB0qtR3tihMTuOTQYdTgxKGbEEhz9wi/eKTqH4+D+A m1J95/rJl1vpDX7SQ/TUwnNaIG5Bp+DDFeRJVGxgtxXEYvzLlZbt84NAAFYueqbuLot301DbI33 RhM5Y6kozXc0XTpLX X-Received: by 2002:a05:622a:1a92:b0:3b6:309e:dfe1 with SMTP id s18-20020a05622a1a9200b003b6309edfe1mr8968769qtc.3.1676972337086; Tue, 21 Feb 2023 01:38:57 -0800 (PST) X-Google-Smtp-Source: AK7set+p6Xvxm9V7AIYXQkW1fmOdaYaqQP1z96A/mL/2xugaW5HkHIJ/25vUgMZC9XoU5je+Jxh5mA== X-Received: by 2002:a05:622a:1a92:b0:3b6:309e:dfe1 with SMTP id s18-20020a05622a1a9200b003b6309edfe1mr8968754qtc.3.1676972336798; Tue, 21 Feb 2023 01:38:56 -0800 (PST) Received: from gerbillo.redhat.com (146-241-121-8.dyn.eolo.it. [146.241.121.8]) by smtp.gmail.com with ESMTPSA id x191-20020a3763c8000000b007402fdda195sm2837520qkb.123.2023.02.21.01.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 01:38:56 -0800 (PST) Message-ID: <35332e079ffea4cc91a4d21fdbf9d2ba244ac203.camel@redhat.com> Subject: Re: [PATCH v2] bnx2: remove deadcode in bnx2_init_cpus() From: Paolo Abeni To: Maxim Korotkov , Rasesh Mody Cc: GR-Linux-NIC-Dev@marvell.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michael Chan , Vadim Fedorenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Date: Tue, 21 Feb 2023 10:38:52 +0100 In-Reply-To: <20230219152225.3339-1-korotkov.maxim.s@gmail.com> References: <20230219152225.3339-1-korotkov.maxim.s@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2023-02-19 at 18:22 +0300, Maxim Korotkov wrote: > The load_cpu_fw function has no error return code > and always returns zero. Checking the value returned by > this function does not make sense. > As a result, bnx2_init_cpus() will also return only zero > Therefore, it will be safe to change the type of functions > to void and remove checking >=20 > Found by Security Code and Linux Verification > Center (linuxtesting.org) with SVACE >=20 > Fixes: 57579f7629a3 ("bnx2: Use request_firmware()") > Signed-off-by: Maxim Korotkov I agree with Vadim, this looks like net-next material. The net-next tree is currently closed. Please re-post when net-next re- opens, in ~2 weeks, with the Fixes tag stripped. Thanks! Paolo