Netdev List
 help / color / mirror / Atom feed
From: Somnath Kotur <somnath.kotur@emulex.com>
To: <netdev@vger.kernel.org>
Cc: Somnath Kotur <somnath.kotur@emulex.com>,
	Sathya Perla <Sathya.Perla@emulex.com>
Subject: [PATCH net-next 4/5] be2net: Fix EEH error reset before a flash dump completes
Date: Wed, 2 May 2012 19:11:01 +0530	[thread overview]
Message-ID: <3533eec3-eb4d-4629-a4db-ee594cf13274@exht1.ad.emulex.com> (raw)

An EEH error can cause the FW to trigger a flash debug dump.
Resetting the card while flash dump is in progress can cause it not to recover.
Wait for it to finish before letting EEH flow to reset the card.

Signed-off-by: Sathya Perla <Sathya.Perla@emulex.com>
Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index b7bc905..6d5d30b 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3821,6 +3821,11 @@ static pci_ers_result_t be_eeh_err_detected(struct pci_dev *pdev,
 
 	pci_disable_device(pdev);
 
+	/* The error could cause the FW to trigger a flash debug dump.
+	 * Resetting the card while flash dump is in progress
+	 * can cause it not to recover; wait for it to finish
+	 */
+	ssleep(30);
 	return PCI_ERS_RESULT_NEED_RESET;
 }
 
-- 
1.5.6.1

             reply	other threads:[~2012-05-02 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 13:41 Somnath Kotur [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-30  6:05 [PATCH net-next 4/5] be2net: Fix EEH error reset before a flash dump completes Somnath Kotur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3533eec3-eb4d-4629-a4db-ee594cf13274@exht1.ad.emulex.com \
    --to=somnath.kotur@emulex.com \
    --cc=Sathya.Perla@emulex.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox