public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Ido Schimmel <idosch@nvidia.com>,
	Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
	Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>,
	Amit Cohen <amcohen@nvidia.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 3/3] selftests: forwarding: fix pedit tests failure with br_netfilter enabled
Date: Tue, 17 Feb 2026 13:33:39 +0100	[thread overview]
Message-ID: <354ecaee-7b66-4c8f-8293-30e68f1a3a1c@redhat.com> (raw)
In-Reply-To: <20260215094520.GC114305@shredder>

On 2/15/26 10:45 AM, Ido Schimmel wrote:
> On Fri, Feb 13, 2026 at 01:19:07PM +0000, Aleksei Oladko wrote:
>> The tests use the tc pedit action to modify the IPv4 source address
>> ("pedit ex munge ip src set"), but the IP header checksum is not
>> recalculated after the modification. As a result, the modified packet
>> fails sanity checks in br_netfilter after bridging and is dropped,
>> which causes the test to fail.
>>
>> Fix this by ensuring net.bridge.bridge-nf-call-iptables is set to 0
>> during the test execution. This prevents the bridge from passing
>> L2 traffic to netfilter, bypasing the checksum validation that
> 
> s/bypasing/bypassing/

No need to resubmit, I'll fix it while applying.

/P


  reply	other threads:[~2026-02-17 12:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 13:19 [PATCH net v2 0/3] selftests: forwarding: fix br_netfilter related test failures Aleksei Oladko
2026-02-13 13:19 ` [PATCH net v2 1/3] selftests: forwarding: vxlan_bridge_1d: fix test failure with br_netfilter enabled Aleksei Oladko
2026-02-15  9:42   ` Ido Schimmel
2026-02-13 13:19 ` [PATCH net v2 2/3] selftests: forwarding: vxlan_bridge_1d_ipv6: " Aleksei Oladko
2026-02-15  9:43   ` Ido Schimmel
2026-02-13 13:19 ` [PATCH net v2 3/3] selftests: forwarding: fix pedit tests " Aleksei Oladko
2026-02-15  9:45   ` Ido Schimmel
2026-02-17 12:33     ` Paolo Abeni [this message]
2026-02-17 12:40 ` [PATCH net v2 0/3] selftests: forwarding: fix br_netfilter related test failures patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=354ecaee-7b66-4c8f-8293-30e68f1a3a1c@redhat.com \
    --to=pabeni@redhat.com \
    --cc=aleksey.oladko@virtuozzo.com \
    --cc=amcohen@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox