From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Laight Subject: RE: [PATCH net 3/5] sctp: only allow the asoc reset when the asoc outq is empty Date: Mon, 27 Nov 2017 10:06:39 +0000 Message-ID: <3550c48ecea24515965aeb4753b2caac@AcuMS.aculab.com> References: <49b01e67e4cc1f8a0be85ffefdee51dad6ae3286.1511614961.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT Cc: "davem@davemloft.net" , Marcelo Ricardo Leitner , Neil Horman To: 'Xin Long' , network dev , "linux-sctp@vger.kernel.org" Return-path: Received: from smtp-out6.electric.net ([192.162.217.185]:58484 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbdK0KGZ (ORCPT ); Mon, 27 Nov 2017 05:06:25 -0500 In-Reply-To: <49b01e67e4cc1f8a0be85ffefdee51dad6ae3286.1511614961.git.lucien.xin@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long > Sent: 25 November 2017 13:06 > > As it says in rfc6525#section5.1.4, before sending the request, > > C2: The sender has either no outstanding TSNs or considers all > outstanding TSNs abandoned. > > Prior to this patch, it tried to consider all outstanding TSNs abandoned > by dropping all chunks in all outqs with sctp_outq_free (even including > sacked, retransmit and transmitted queues) when doing this reset, which > is too aggressive. > > To make it work gently, this patch will only allow the asoc reset when > the sender has no outstanding TSNs by checking if unsent, transmitted > and retransmit are all empty with sctp_outq_is_empty before sending > and processing the request. Doesn't that rather defeat the point of a reset? David