netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"horms@kernel.org" <horms@kernel.org>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation
Date: Thu, 12 Jun 2025 07:42:05 +0000	[thread overview]
Message-ID: <3553c84b61b24ebe99846136123062f5@realtek.com> (raw)
In-Reply-To: <20250611142523.67e7d984@kernel.org>

> On Tue, 10 Jun 2025 17:55:18 +0800 Justin Lai wrote:
> > Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
> >
> > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> > ---
> >  drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > index 4d37217e9a14..c22dd573418a 100644
> > --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > @@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev,
> struct net_device **dev_out,
> >       int ret = -ENOMEM;
> >
> >       /* dev zeroed in alloc_etherdev */
> > -     dev = alloc_etherdev_mq(sizeof(struct rtase_private),
> > -                             RTASE_FUNC_TXQ_NUM);
> > +     dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
> > +                              RTASE_FUNC_TXQ_NUM,
> RTASE_FUNC_RXQ_NUM);
> >       if (!dev)
> >               goto err_out;
> >
> 
> $ git grep RTASE_FUNC_.XQ_NUM
> drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_TXQ_NUM
> 1
> drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_RXQ_NUM
> 1
> 
> This patch is a nop?
> --
> pw-bot: reject

Hi Jakub,

Sorry about this, but this patch needs to be abandoned for now. It's
currently non-functional, and we'll resubmit it in the future together
with changes that support user-configurable queue numbers.
 
Thanks,
Justin

      reply	other threads:[~2025-06-12  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  9:55 [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation Justin Lai
2025-06-11 21:25 ` Jakub Kicinski
2025-06-12  7:42   ` Justin Lai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3553c84b61b24ebe99846136123062f5@realtek.com \
    --to=justinlai0215@realtek.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=larry.chiu@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).