From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH iproute2] ss: add support for delivered and delivered_ce
 fields
Date: Wed, 28 Nov 2018 21:10:16 -0800
Message-ID: <35597e1d-3215-2157-7b00-b8c9bcfccb17@gmail.com>
References: <20181126222953.179043-1-edumazet@google.com>
 <20181128160114.1601f7e2@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: David Ahern <dsahern@gmail.com>, netdev <netdev@vger.kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>,
        Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f195.google.com ([209.85.214.195]:38060 "EHLO
        mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727402AbeK2QOW (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 29 Nov 2018 11:14:22 -0500
Received: by mail-pl1-f195.google.com with SMTP id e5so419816plb.5
        for <netdev@vger.kernel.org>; Wed, 28 Nov 2018 21:10:18 -0800 (PST)
In-Reply-To: <20181128160114.1601f7e2@xeon-e3>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 11/28/2018 04:01 PM, Stephen Hemminger wrote:
> On Mon, 26 Nov 2018 14:29:53 -0800
> Eric Dumazet <edumazet@google.com> wrote:
> 
>> Kernel support was added in linux-4.18 in commit feb5f2ec6464
>> ("tcp: export packets delivery info")
>>
>> Tested:
>>
>> ss -ti
>> ...
>> ESTAB   0 2270520      [2607:f8b0:8099:e16::]:47646   [2607:f8b0:8099:e18::]:38953
>> 	 ts sack cubic wscale:8,8 rto:7 rtt:2.824/0.278 mss:1428
>>      pmtu:1500 rcvmss:536 advmss:1428 cwnd:89 ssthresh:62 bytes_acked:2097871945
>>     segs_out:1469144 segs_in:65221 data_segs_out:1469142 send 360.0Mbps lastsnd:2
>>     lastrcv:99231 lastack:2 pacing_rate 431.9Mbps delivery_rate 246.4Mbps
>> (*) delivered:1469099 delivered_ce:424799
>>     busy:99231ms unacked:44 rcv_space:14280 rcv_ssthresh:65535
>>     notsent:2207688 minrtt:0.228
>>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
> 
> Applied
> 

Thanks Stephen

BTW, it seems ss had some recent regression :

Old ss command was happy with "ss dst 127.0.0.1 and not dst :12865"

But current one is not.

root@edumazet-glaptop:/usr/src/iproute2# ss -V
ss utility, iproute2-ss171113

root@edumazet-glaptop:/usr/src/iproute2# ss dst 127.0.0.1 and not dst :12865
Netid  State      Recv-Q Send-Q                        Local Address:Port                                         Peer Address:Port                
tcp    ESTAB      0      0                                 127.0.0.1:45368                                           127.0.0.1:999                  
tcp    ESTAB      0      0                                 127.0.0.1:999                                             127.0.0.1:45368   

             
root@edumazet-glaptop:/usr/src/iproute2# misc/ss -V
ss utility, iproute2-ss181023

root@edumazet-glaptop:/usr/src/iproute2# misc/ss dst 127.0.0.1 and not dst :12865
ss: bison bellows (while parsing filter): "syntax error!" Sorry.
Usage: ss [ OPTIONS ]
       ss [ OPTIONS ] [ FILTER ]
...