From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: add link_down_events statistic
Date: Mon, 12 May 2025 11:27:09 +0200 [thread overview]
Message-ID: <355fc4f1-0116-4028-a455-ec76772f19b3@molgen.mpg.de> (raw)
In-Reply-To: <4012b88a-091d-4f81-92ab-ad32727914ff@linux.intel.com>
Dear Martyna,
Thank you for your reply.
Am 14.04.25 um 15:12 schrieb Szapar-Mudlaw, Martyna:
> On 4/9/2025 2:08 PM, Paul Menzel wrote:
>> Am 09.04.25 um 13:36 schrieb Martyna Szapar-Mudlaw:
>>> Introduce a new ethtool statistic to ice driver, `link_down_events`,
>>> to track the number of times the link transitions from up to down.
>>> This counter can help diagnose issues related to link stability,
>>> such as port flapping or unexpected link drops.
>>>
>>> The counter increments when a link-down event occurs and is exposed
>>> via ethtool stats as `link_down_events.nic`.
>>
>> It’d be great if you pasted an example output.
>
> In v2 (which I just submitted) the generic ethtool statistic is used for
> this, instead of driver specific, so I guess no need to paste the
> example output now.
I think it’s always good also as a reference how to test the patch. I
just saw your v3. Should you resent, it’d be great if you added the
example output.
[…]
Kind regards,
Paul
next prev parent reply other threads:[~2025-05-12 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 11:36 [PATCH iwl-next 0/2] Add link_down_events ethtool stat to ixgbe and ice Martyna Szapar-Mudlaw
2025-04-09 11:36 ` [PATCH iwl-next 1/2] ice: add link_down_events statistic Martyna Szapar-Mudlaw
2025-04-09 12:06 ` Ido Schimmel
2025-04-14 13:03 ` Szapar-Mudlaw, Martyna
2025-04-09 12:08 ` [Intel-wired-lan] " Paul Menzel
2025-04-14 13:12 ` Szapar-Mudlaw, Martyna
2025-05-12 9:27 ` Paul Menzel [this message]
2025-05-15 10:52 ` Szapar-Mudlaw, Martyna
2025-04-09 11:36 ` [PATCH iwl-next 2/2] ixgbe: " Martyna Szapar-Mudlaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=355fc4f1-0116-4028-a455-ec76772f19b3@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=martyna.szapar-mudlaw@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).