From: David Ahern <dsahern@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>, David Miller <davem@davemloft.net>
Cc: Jianlin Shi <jishi@redhat.com>, Wei Wang <weiwan@google.com>,
Martin KaFai Lau <kafai@fb.com>,
Eric Dumazet <edumazet@google.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v3 1/2] ipv6: Dump route exceptions too in rt6_dump_route()
Date: Mon, 10 Jun 2019 15:31:37 -0600 [thread overview]
Message-ID: <35689c52-0969-0103-663b-c9f909f4c727@gmail.com> (raw)
In-Reply-To: <f5ca22e91017e90842ee00aa4fd41dcdf7a6e99b.1560016091.git.sbrivio@redhat.com>
On 6/8/19 12:12 PM, Stefano Brivio wrote:
> To avoid dumping exceptions if not requested, we can, in the future, add
> support for NLM_F_MATCH as described by RFC 3549. This would also require
> some changes in iproute2: whenever a 'cache' argument is given,
> RTM_F_CLONED should be set in the dump request and, when filtering in the
> kernel is desired, NLM_F_MATCH should be also passed. We can then signal
> filtering with the NLM_F_DUMP_FILTERED whenever a NLM_F_MATCH flag caused
> it.
NLM_F_MATCH is set today. iproute2 for example uses NLM_F_DUMP for dump
requests and NLM_F_DUMP is defined as:
#define NLM_F_DUMP (NLM_F_ROOT|NLM_F_MATCH)
further, the kernel already supports kernel side filtering now for
routes. See ip_valid_fib_dump_req.
next prev parent reply other threads:[~2019-06-10 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 18:12 [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions Stefano Brivio
2019-06-08 18:12 ` [PATCH net v3 1/2] ipv6: Dump route exceptions too in rt6_dump_route() Stefano Brivio
2019-06-10 21:31 ` David Ahern [this message]
2019-06-10 21:45 ` Stefano Brivio
2019-06-10 21:47 ` David Ahern
2019-06-10 21:55 ` Stefano Brivio
2019-06-08 18:12 ` [PATCH net v3 2/2] ip6_fib: Don't discard nodes with valid routing information in fib6_locate_1() Stefano Brivio
2019-06-10 21:38 ` [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions David Ahern
2019-06-10 21:50 ` Martin Lau
2019-06-10 21:53 ` Stefano Brivio
2019-06-10 22:47 ` Stefano Brivio
2019-06-11 20:19 ` Martin Lau
2019-06-11 21:09 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35689c52-0969-0103-663b-c9f909f4c727@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jishi@redhat.com \
--cc=kafai@fb.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).