From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
To: Himanshu Jha <himanshujha199640@gmail.com>,
Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
amitkarwar@gmail.com, nishants@marvell.com, gbhat@marvell.com,
huxm@marvell.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mwifiex: Use put_unaligned_le32
Date: Thu, 5 Oct 2017 14:54:38 -0700 [thread overview]
Message-ID: <357bb728-f324-5c9f-c92c-08c57f22ce75@quantenna.com> (raw)
In-Reply-To: <20171005190730.GA8043@himanshu-Vostro-3559>
On 10/05/2017 12:07 PM, Himanshu Jha wrote:
>>
>> In this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It
>> seems that asm-generic/unaligned.h is set up to include different
>> headers, based on the expected architecture behavior.
>>
> Yes, asm-generic/unaligned.h looks more appopriate and is most generic
> implementation of unaligned accesses and arc specific.
>
Probably the idea is that each ARCH knows exactly what is the best way
to do unaligned access, so common code (like drivers) should include
ARCH-specific asm/unaligned.h only. It will then decide how to do that
and will include asm-generic/unaligned.h itself, if required.
next prev parent reply other threads:[~2017-10-05 21:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:28 [PATCH] mwifiex: Use put_unaligned_le32 Himanshu Jha
2017-10-05 7:23 ` Kalle Valo
2017-10-05 8:34 ` Himanshu Jha
2017-10-05 8:41 ` Kalle Valo
2017-10-05 15:22 ` Himanshu Jha
2017-10-05 18:02 ` Brian Norris
2017-10-05 19:07 ` Himanshu Jha
2017-10-05 21:54 ` Igor Mitsyanko [this message]
2017-10-06 13:31 ` Kalle Valo
2017-10-07 3:31 ` kbuild test robot
2017-10-07 5:17 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=357bb728-f324-5c9f-c92c-08c57f22ce75@quantenna.com \
--to=igor.mitsyanko.os@quantenna.com \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=gbhat@marvell.com \
--cc=himanshujha199640@gmail.com \
--cc=huxm@marvell.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).