Re: [PATCH net-next 0/4] mlx5: Support setting a parent for a devlink rate node

[Jacob Keller <jacob.e.keller@intel.com>]

On 3/10/2025 2:26 PM, Tariq Toukan wrote:
> Hi,
> 
> This series by Carolina adds mlx5 support for the setting of a parent to
> devlink rate nodes.
> 
> By introducing a hierarchical level to scheduling nodes, these changes
> allow for more granular control over bandwidth allocation and isolation
> of Virtual Functions.
> 
> Function renaming for parent setting on leafs:
> - net/mlx5: Rename devlink rate parent set function for leaf nodes
> 
> Add support for hierarchy level tracking:
> - net/mlx5: Introduce hierarchy level tracking on scheduling nodes
> - net/mlx5: Preserve rate settings when creating a rate node
> 
> Support setting parent for rate nodes:
> - net/mlx5: Add support for setting parent of nodes
> 
> Regards,
> Tariq
> 
> Carolina Jubran (4):
>   net/mlx5: Rename devlink rate parent set function for leaf nodes
>   net/mlx5: Introduce hierarchy level tracking on scheduling nodes
>   net/mlx5: Preserve rate settings when creating a rate node
>   net/mlx5: Add support for setting parent of nodes
> 

Nice work. The whole series was a pleasant read.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  .../net/ethernet/mellanox/mlx5/core/devlink.c |   3 +-
>  .../net/ethernet/mellanox/mlx5/core/esw/qos.c | 146 ++++++++++++++++--
>  .../net/ethernet/mellanox/mlx5/core/esw/qos.h |  12 +-
>  3 files changed, 143 insertions(+), 18 deletions(-)
> 
> 
> base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe