From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: Wolfgang Walter <linux@stwm.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3.12+
Date: Tue, 09 Dec 2014 09:54:02 +0100 [thread overview]
Message-ID: <3594382.qsqLZcX7yO@storm> (raw)
In-Reply-To: <5642727.qTG53DqrAk@h2o.as.studentenwerk.mhn.de>
On Monday, 8. December 2014 23:20:42 Wolfgang Walter wrote:
> Am Freitag, 5. Dezember 2014, 05:26:25 schrieb Eric Dumazet:
> > On Fri, 2014-12-05 at 13:09 +0100, Wolfgang Walter wrote:
> > > Hello,
> > >
> > > as reverting this patch fixes this rather annoying problem: is it
> > > dangerous to revert it as a workaround until the root cause is found?
> >
> > Unfortunately no, this patch fixes a serious issue.
> >
> > We need to find the root cause of your problem instead of trying to work
> > around it.
>
> I only wanted to use it as local workaround here.
>
>
> I looked a bit at at code. I'm not familiar with the network code, though
> :-).
If it helps, I'm running the reverted patch on five production boxes hitherto
without a hiccup. As far as I understood the original commit message,
some packet counters might me wrong without it.
@Eric: What could possibly go wrong(tm)? :)
Of course a real fix is preferred over this band-aid.
Cheers,
Thomas
next prev parent reply other threads:[~2014-12-09 8:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 11:44 [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3.12+ Thomas Jarosch
2014-12-01 10:25 ` Herbert Xu
2014-12-01 11:20 ` Thomas Jarosch
2014-12-31 13:39 ` tcp: Do not apply TSO segment limit to non-TSO packets Herbert Xu
2014-12-31 13:42 ` Herbert Xu
2015-01-02 18:24 ` Eric Dumazet
2015-01-02 20:36 ` David Miller
2015-01-02 22:01 ` Herbert Xu
2015-01-02 22:06 ` David Miller
2015-01-02 22:09 ` Herbert Xu
2015-01-02 21:13 ` David Miller
2015-01-16 10:45 ` Thomas Jarosch
2015-01-16 10:50 ` Herbert Xu
2015-01-16 11:03 ` Thomas Jarosch
2015-01-19 13:39 ` Thomas Jarosch
[not found] ` <CANn89i+U-PFbuUrp08s3Ec8BmjPFq1zj8Aj2=vPVO4-iiLkTuw@mail.gmail.com>
2015-01-19 22:36 ` Herbert Xu
2015-01-19 22:38 ` Eric Dumazet
2015-01-19 22:40 ` Herbert Xu
2014-12-01 13:17 ` [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3.12+ Wolfgang Walter
2014-12-01 16:41 ` Wolfgang Walter
2014-12-05 12:09 ` Wolfgang Walter
2014-12-05 13:26 ` Eric Dumazet
2014-12-08 22:20 ` Wolfgang Walter
2014-12-09 8:54 ` Thomas Jarosch [this message]
2014-12-09 14:26 ` [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3 Eric Dumazet
2014-12-09 14:49 ` Thomas Jarosch
2014-12-09 20:36 ` Wolfgang Walter
2014-12-09 21:40 ` Eric Dumazet
2014-12-10 18:34 ` Wolfgang Walter
2014-12-10 19:10 ` Eric Dumazet
2014-12-11 0:36 ` Wolfgang Walter
2014-12-12 16:58 ` Wolfgang Walter
2014-12-12 17:27 ` Eric Dumazet
2014-12-12 20:31 ` Wolfgang Walter
2014-12-12 21:30 ` Thomas Jarosch
2014-12-12 22:31 ` Eric Dumazet
2014-12-12 23:47 ` Wolfgang Walter
2014-12-13 0:15 ` Eric Dumazet
2014-12-13 0:43 ` Wolfgang Walter
2014-12-15 18:04 ` Wolfgang Walter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3594382.qsqLZcX7yO@storm \
--to=thomas.jarosch@intra2net.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux@stwm.de \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox