From: David Ahern <dsahern@gmail.com>
To: wenxu <wenxu@ucloud.cn>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] vrf: Add VRF_F_BYPASS_RCV_NF flag to vrf device
Date: Thu, 10 Jan 2019 10:00:06 -0700 [thread overview]
Message-ID: <3595b09c-0000-0d67-e080-0341bdbf307e@gmail.com> (raw)
In-Reply-To: <493e5cb3-224c-f83b-4fbd-caa1703bb379@ucloud.cn>
On 1/10/19 8:21 AM, wenxu wrote:
>
> How about the status of this patch? Should I resubmit it?
>
I do not like the need for a flag when the VRF is created. If something
changes with the firewall rules, it means a user has to delete and
re-create the VRF which is really expensive.
It would be better to detect this on the fly - similar to how it detects
the default qdisc and avoids the recirculation on Tx when the qdisc is
the default.
next prev parent reply other threads:[~2019-01-10 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 7:38 [PATCH net-next] vrf: Add VRF_F_BYPASS_RCV_NF flag to vrf device wenxu
2018-12-28 14:42 ` David Ahern
2019-01-10 15:21 ` wenxu
2019-01-10 17:00 ` David Ahern [this message]
2019-01-02 21:50 ` David Ahern
2019-01-02 22:19 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3595b09c-0000-0d67-e080-0341bdbf307e@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).