From: Daniel Borkmann <daniel@iogearbox.net>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
bjorn.topel@intel.com, ast@fb.com, netdev@vger.kernel.org
Cc: qi.z.zhang@intel.com, pavel@fastnetmon.com
Subject: Re: [PATCH bpf 4/4] xsk: fix potential race in SKB TX completion code
Date: Wed, 27 Jun 2018 23:00:08 +0200 [thread overview]
Message-ID: <35ad45f2-15b2-c022-6b01-ccb0929437bf@iogearbox.net> (raw)
In-Reply-To: <54fa1b60-ebae-94a2-8036-06df6c05307a@gmail.com>
On 06/27/2018 05:55 PM, Eric Dumazet wrote:
> On 06/27/2018 07:02 AM, Magnus Karlsson wrote:
>> There was a potential race in the TX completion code for
>> the SKB case when the TX napi thread and the error path
>> of the sendmsg code could both call the SKB destructor
>> at the same time. Fixed by introducing a spin_lock in the
>> destructor.
>
> Wow, what is the impact on performance ?
>
> Please describe a bit more what is the problem.
Agree, this should at min be better clarified in the commit log.
Thanks,
Daniel
next prev parent reply other threads:[~2018-06-27 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 14:02 [PATCH bpf 0/4] Bug fixes to the SKB TX path of AF_XDP Magnus Karlsson
2018-06-27 14:02 ` [PATCH bpf 1/4] xsk: fix potential lost completion message in SKB path Magnus Karlsson
2018-06-28 17:10 ` Song Liu
2018-06-27 14:02 ` [PATCH bpf 2/4] xsk: frame could be completed more than once " Magnus Karlsson
2018-06-27 18:19 ` Song Liu
2018-06-27 14:02 ` [PATCH bpf 3/4] samples/bpf: deal with EBUSY return code from sendmsg in xdpsock sample Magnus Karlsson
2018-06-27 18:21 ` Song Liu
2018-06-27 14:02 ` [PATCH bpf 4/4] xsk: fix potential race in SKB TX completion code Magnus Karlsson
2018-06-27 15:55 ` Eric Dumazet
2018-06-27 21:00 ` Daniel Borkmann [this message]
2018-06-28 8:31 ` Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ad45f2-15b2-c022-6b01-ccb0929437bf@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=bjorn.topel@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@fastnetmon.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox