From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jordan Rife <jordan@jrife.io>
Cc: Aditi Ghag <aditi.ghag@isovalent.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v7 bpf-next 1/7] bpf: udp: Make mem flags configurable through bpf_iter_udp_realloc_batch
Date: Fri, 2 May 2025 14:31:28 -0700 [thread overview]
Message-ID: <35aee73f-171c-4c64-9144-ff97afd8801c@linux.dev> (raw)
In-Reply-To: <20250502161528.264630-2-jordan@jrife.io>
On 5/2/25 9:15 AM, Jordan Rife wrote:
> Prepare for the next patch which needs to be able to choose either
> GFP_USER or GFP_NOWAIT for calls to bpf_iter_udp_realloc_batch.
>
> Signed-off-by: Jordan Rife <jordan@jrife.io>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
> net/ipv4/udp.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 2742cc7602bb..6a3c351aa06e 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -3401,7 +3401,7 @@ struct bpf_udp_iter_state {
> };
>
> static int bpf_iter_udp_realloc_batch(struct bpf_udp_iter_state *iter,
> - unsigned int new_batch_sz);
> + unsigned int new_batch_sz, int flags);
I also made a minor change from "int flags" to "gfp_t flags".
next prev parent reply other threads:[~2025-05-02 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 16:15 [PATCH v7 bpf-next 0/7] bpf: udp: Exactly-once socket iteration Jordan Rife
2025-05-02 16:15 ` [PATCH v7 bpf-next 1/7] bpf: udp: Make mem flags configurable through bpf_iter_udp_realloc_batch Jordan Rife
2025-05-02 21:31 ` Martin KaFai Lau [this message]
2025-05-02 16:15 ` [PATCH v7 bpf-next 2/7] bpf: udp: Make sure iter->batch always contains a full bucket snapshot Jordan Rife
2025-05-02 16:15 ` [PATCH v7 bpf-next 3/7] bpf: udp: Get rid of st_bucket_done Jordan Rife
2025-05-02 16:15 ` [PATCH v7 bpf-next 4/7] bpf: udp: Use bpf_udp_iter_batch_item for bpf_udp_iter_state batch items Jordan Rife
2025-05-02 21:22 ` Martin KaFai Lau
2025-05-02 21:31 ` Jordan Rife
2025-05-02 16:15 ` [PATCH v7 bpf-next 5/7] bpf: udp: Avoid socket skips and repeats during iteration Jordan Rife
2025-05-02 21:29 ` Martin KaFai Lau
2025-05-02 16:15 ` [PATCH v7 bpf-next 6/7] selftests/bpf: Return socket cookies from sock_iter_batch progs Jordan Rife
2025-05-02 16:15 ` [PATCH v7 bpf-next 7/7] selftests/bpf: Add tests for bucket resume logic in UDP socket iterators Jordan Rife
2025-05-02 21:20 ` [PATCH v7 bpf-next 0/7] bpf: udp: Exactly-once socket iteration patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35aee73f-171c-4c64-9144-ff97afd8801c@linux.dev \
--to=martin.lau@linux.dev \
--cc=aditi.ghag@isovalent.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jordan@jrife.io \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).